<div dir="ltr">Is there missing test coverage for these cases?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Nov 5, 2013 at 6:16 AM, John Thompson <span dir="ltr"><<a href="mailto:John.Thompson.JTSoftware@gmail.com" target="_blank">John.Thompson.JTSoftware@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: jtsoftware<br>
Date: Tue Nov  5 08:16:11 2013<br>
New Revision: 194079<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=194079&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=194079&view=rev</a><br>
Log:<br>
[extra] pp-trace - Fixed problems found while writing docs.<br>
<br>
Modified:<br>
    clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp<br>
    clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h<br>
<br>
Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp?rev=194079&r1=194078&r2=194079&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp?rev=194079&r1=194078&r2=194079&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp (original)<br>
+++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.cpp Tue Nov  5 08:16:11 2013<br>
@@ -166,7 +166,7 @@ void PPCallbacksTracker::Ident(clang::So<br>
                                const std::string &Str) {<br>
   beginCallback("Ident");<br>
   appendArgument("Loc", Loc);<br>
-  appendArgument("Path", Str);<br>
+  appendQuotedArgument("Str", Str);<br>
 }<br>
<br>
 // Callback invoked when start reading any pragma directive.<br>
@@ -175,7 +175,7 @@ PPCallbacksTracker::PragmaDirective(clan<br>
                                     clang::PragmaIntroducerKind Introducer) {<br>
   beginCallback("PragmaDirective");<br>
   appendArgument("Loc", Loc);<br>
-  appendArgument("Path", Introducer, PragmaIntroducerKindStrings);<br>
+  appendArgument("Introducer", Introducer, PragmaIntroducerKindStrings);<br>
 }<br>
<br>
 // Callback invoked when a #pragma comment directive is read.<br>
<br>
Modified: clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h?rev=194079&r1=194078&r2=194079&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h?rev=194079&r1=194078&r2=194079&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h (original)<br>
+++ clang-tools-extra/trunk/pp-trace/PPCallbacksTracker.h Tue Nov  5 08:16:11 2013<br>
@@ -160,9 +160,6 @@ public:<br>
   /// \brief Append a string to the top trace item.<br>
   void append(const char *Str);<br>
<br>
-  /// \brief Format and append a string to the top trace item.<br>
-  void appendFormatted(const char *Format, ...);<br>
-<br>
   /// \brief Append a bool argument to the top trace item.<br>
   void appendArgument(const char *Name, bool Value);<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>