<div dir="ltr">Woot!  ~3 year old bug closed!</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Nov 1, 2013 at 2:54 PM, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Maybe you want to close PR8682? =)</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br>
<br><div class="gmail_quote">On Fri, Nov 1, 2013 at 2:19 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rtrieu<br>
Date: Fri Nov  1 16:19:43 2013<br>
New Revision: 193887<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193887&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=193887&view=rev</a><br>
Log:<br>
Disable -Wtautological-constant-out-of-range-compare in template instantiations.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Sema/SemaChecking.cpp<br>
    cfe/trunk/test/SemaCXX/compare.cpp<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=193887&r1=193886&r2=193887&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=193887&r1=193886&r2=193887&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaChecking.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaChecking.cpp Fri Nov  1 16:19:43 2013<br>
@@ -4806,6 +4806,10 @@ static void DiagnoseOutOfRangeComparison<br>
                                          Expr *Constant, Expr *Other,<br>
                                          llvm::APSInt Value,<br>
                                          bool RhsConstant) {<br>
+  // Disable warning in template instantiations.<br>
+  if (!S.ActiveTemplateInstantiations.empty())<br>
+    return;<br>
+<br>
   // 0 values are handled later by CheckTrivialUnsignedComparison().<br>
   if (Value == 0)<br>
     return;<br>
<br>
Modified: cfe/trunk/test/SemaCXX/compare.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/compare.cpp?rev=193887&r1=193886&r2=193887&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/compare.cpp?rev=193887&r1=193886&r2=193887&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/test/SemaCXX/compare.cpp (original)<br>
+++ cfe/trunk/test/SemaCXX/compare.cpp Fri Nov  1 16:19:43 2013<br>
@@ -355,3 +355,29 @@ void test9(int x) {<br>
   };<br>
   (void)((E)x == 1);<br>
 }<br>
+<br>
+namespace templates {<br>
+  template<class T> T max();<br>
+<br>
+  template<> constexpr int max<int>() { return <a href="tel:2147483647" value="+12147483647" target="_blank">2147483647</a>; };<br>
+<br>
+  template<typename T><br>
+  bool less_than_max(short num, T value) {<br>
+    const T vmax = max<T>();<br>
+    return (vmax >= num);  // no warning<br>
+  }<br>
+<br>
+  template<typename T><br>
+  bool less_than_max(short num) {<br>
+    // This should trigger one warning on the template pattern, and not a<br>
+    // warning per specialization.<br>
+    return num < max<int>();  // expected-warning{{comparison of constant <a href="tel:2147483647" value="+12147483647" target="_blank">2147483647</a> with expression of type 'short' is always true}}<br>

+  }<br>
+<br>
+  void test10(short num, int x) {<br>
+    less_than_max(num, x);<br>
+    less_than_max<int>(num);<br>
+    less_than_max<long>(num);<br>
+    less_than_max<short>(num);<br>
+  }<br>
+}<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>