<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Oct 31, 2013 at 11:16 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Any good ideas where? We have a testing guide that most folks don't work....</div>
</blockquote><div><br></div><div><a href="http://llvm.org/docs/DeveloperPolicy.html#test-cases">http://llvm.org/docs/DeveloperPolicy.html#test-cases</a> is probably the closest we have to "normative" documentation regarding testing practices. I feel like this issue might be too "micro" for that location though. What do you think?</div>
<div><br></div><div><br></div><a href="http://llvm.org/docs/TestingGuide.html">http://llvm.org/docs/TestingGuide.html</a> is really poorly organized which is why I think most folk's don't read it. On the other hand, this topic does seem to fall under the purview of "It documents the structure of the LLVM testing infrastructure, the tools needed to use it, and *how to add and run tests*." (emphasis mine). I guess it could be a subtopic of "Regression Test Structure". Another topic at that level is "Fragile tests", which seems like a similar-in-scope issue. The best name I can think of is "Supplying input files to tests", which is kind of lame. Suggestions? However, TestingGuide is more informative, so I'm not sure that it's a good place to put a "rule".</div>
<div class="gmail_quote"><br>-- Sean Silva<br><br> <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">
<div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Oct 31, 2013 at 3:14 PM, Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">I feel like we should have this rule in a doc somewhere (CodingStandards.rst? it's not really about "code" per se).<span><font color="#888888"><div>
<br><div>-- Sean Silva</div></div></font></span></div><div><div><div class="gmail_extra"><br><br>
<div class="gmail_quote">On Thu, Oct 31, 2013 at 5:29 PM, Dan Gohman <span dir="ltr"><<a href="mailto:dan433584@gmail.com" target="_blank">dan433584@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Author: djg<br>
Date: Thu Oct 31 16:29:44 2013<br>
New Revision: 193805<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193805&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=193805&view=rev</a><br>
Log:<br>
Rename Input to Inputs, for consistency with other tests.<br>
<br>
Added:<br>
clang-tools-extra/trunk/test/pp-trace/Inputs/<br>
- copied from r193801, clang-tools-extra/trunk/test/pp-trace/Input/<br>
Removed:<br>
clang-tools-extra/trunk/test/pp-trace/Input/<br>
Modified:<br>
clang-tools-extra/trunk/test/pp-trace/pp-trace-include.cpp<br>
<br>
Modified: clang-tools-extra/trunk/test/pp-trace/pp-trace-include.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/pp-trace/pp-trace-include.cpp?rev=193805&r1=193804&r2=193805&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/pp-trace/pp-trace-include.cpp?rev=193805&r1=193804&r2=193805&view=diff</a><br>
==============================================================================<br>
--- clang-tools-extra/trunk/test/pp-trace/pp-trace-include.cpp (original)<br>
+++ clang-tools-extra/trunk/test/pp-trace/pp-trace-include.cpp Thu Oct 31 16:29:44 2013<br>
@@ -1,7 +1,7 @@<br>
// RUN: pp-trace %s -undef -target x86_64 -std=c++11 | FileCheck --strict-whitespace %s<br>
<br>
-#include "Input/Level1A.h"<br>
-#include "Input/Level1B.h"<br>
+#include "Inputs/Level1A.h"<br>
+#include "Inputs/Level1B.h"<br>
<br>
// CHECK: ---<br>
// CHECK-NEXT: - Callback: FileChanged<br>
@@ -51,15 +51,15 @@<br>
// CHECK-NEXT: PrevFID: (getFileEntryForID failed)<br>
// CHECK-NEXT: - Callback: InclusionDirective<br>
// CHECK-NEXT: IncludeTok: include<br>
-// CHECK-NEXT: FileName: "Input/Level1A.h"<br>
+// CHECK-NEXT: FileName: "Inputs/Level1A.h"<br>
// CHECK-NEXT: IsAngled: false<br>
-// CHECK-NEXT: FilenameRange: "Input/Level1A.h"<br>
-// CHECK-NEXT: File: "{{.*}}{{[/\\]}}Input/Level1A.h"<br>
+// CHECK-NEXT: FilenameRange: "Inputs/Level1A.h"<br>
+// CHECK-NEXT: File: "{{.*}}{{[/\\]}}Inputs/Level1A.h"<br>
// CHECK-NEXT: SearchPath: "{{.*}}{{[/\\]}}pp-trace"<br>
-// CHECK-NEXT: RelativePath: "Input/Level1A.h"<br>
+// CHECK-NEXT: RelativePath: "Inputs/Level1A.h"<br>
// CHECK-NEXT: Imported: (null)<br>
// CHECK-NEXT: - Callback: FileChanged<br>
-// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Input/Level1A.h:1:1"<br>
+// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Inputs/Level1A.h:1:1"<br>
// CHECK-NEXT: Reason: EnterFile<br>
// CHECK-NEXT: FileType: C_User<br>
// CHECK-NEXT: PrevFID: (invalid)<br>
@@ -68,12 +68,12 @@<br>
// CHECK-NEXT: FileName: "Level2A.h"<br>
// CHECK-NEXT: IsAngled: false<br>
// CHECK-NEXT: FilenameRange: "Level2A.h"<br>
-// CHECK-NEXT: File: "{{.*}}{{[/\\]}}Input/Level2A.h"<br>
-// CHECK-NEXT: SearchPath: "{{.*}}{{[/\\]}}Input"<br>
+// CHECK-NEXT: File: "{{.*}}{{[/\\]}}Inputs/Level2A.h"<br>
+// CHECK-NEXT: SearchPath: "{{.*}}{{[/\\]}}Inputs"<br>
// CHECK-NEXT: RelativePath: "Level2A.h"<br>
// CHECK-NEXT: Imported: (null)<br>
// CHECK-NEXT: - Callback: FileChanged<br>
-// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Input/Level2A.h:1:1"<br>
+// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Inputs/Level2A.h:1:1"<br>
// CHECK-NEXT: Reason: EnterFile<br>
// CHECK-NEXT: FileType: C_User<br>
// CHECK-NEXT: PrevFID: (invalid)<br>
@@ -81,10 +81,10 @@<br>
// CHECK-NEXT: MacroNameTok: MACRO_2A<br>
// CHECK-NEXT: MacroDirective: MD_Define<br>
// CHECK-NEXT: - Callback: FileChanged<br>
-// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Input/Level1A.h:2:1"<br>
+// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Inputs/Level1A.h:2:1"<br>
// CHECK-NEXT: Reason: ExitFile<br>
// CHECK-NEXT: FileType: C_User<br>
-// CHECK-NEXT: PrevFID: "{{.*}}{{[/\\]}}Input/Level2A.h"<br>
+// CHECK-NEXT: PrevFID: "{{.*}}{{[/\\]}}Inputs/Level2A.h"<br>
// CHECK-NEXT: - Callback: MacroDefined<br>
// CHECK-NEXT: MacroNameTok: MACRO_1A<br>
// CHECK-NEXT: MacroDirective: MD_Define<br>
@@ -92,18 +92,18 @@<br>
// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}pp-trace-include.cpp:4:1"<br>
// CHECK-NEXT: Reason: ExitFile<br>
// CHECK-NEXT: FileType: C_User<br>
-// CHECK-NEXT: PrevFID: "{{.*}}{{[/\\]}}Input/Level1A.h"<br>
+// CHECK-NEXT: PrevFID: "{{.*}}{{[/\\]}}Inputs/Level1A.h"<br>
// CHECK-NEXT: - Callback: InclusionDirective<br>
// CHECK-NEXT: IncludeTok: include<br>
-// CHECK-NEXT: FileName: "Input/Level1B.h"<br>
+// CHECK-NEXT: FileName: "Inputs/Level1B.h"<br>
// CHECK-NEXT: IsAngled: false<br>
-// CHECK-NEXT: FilenameRange: "Input/Level1B.h"<br>
-// CHECK-NEXT: File: "{{.*}}{{[/\\]}}Input/Level1B.h"<br>
+// CHECK-NEXT: FilenameRange: "Inputs/Level1B.h"<br>
+// CHECK-NEXT: File: "{{.*}}{{[/\\]}}Inputs/Level1B.h"<br>
// CHECK-NEXT: SearchPath: "{{.*}}{{[/\\]}}pp-trace"<br>
-// CHECK-NEXT: RelativePath: "Input/Level1B.h"<br>
+// CHECK-NEXT: RelativePath: "Inputs/Level1B.h"<br>
// CHECK-NEXT: Imported: (null)<br>
// CHECK-NEXT: - Callback: FileChanged<br>
-// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Input/Level1B.h:1:1"<br>
+// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}Inputs/Level1B.h:1:1"<br>
// CHECK-NEXT: Reason: EnterFile<br>
// CHECK-NEXT: FileType: C_User<br>
// CHECK-NEXT: PrevFID: (invalid)<br>
@@ -114,6 +114,6 @@<br>
// CHECK-NEXT: Loc: "{{.*}}{{[/\\]}}pp-trace-include.cpp:5:1"<br>
// CHECK-NEXT: Reason: ExitFile<br>
// CHECK-NEXT: FileType: C_User<br>
-// CHECK-NEXT: PrevFID: "{{.*}}{{[/\\]}}Input/Level1B.h"<br>
+// CHECK-NEXT: PrevFID: "{{.*}}{{[/\\]}}Inputs/Level1B.h"<br>
// CHECK-NEXT: - Callback: EndOfMainFile<br>
// CHECK-NEXT: ...<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>