<p dir="ltr"><br>
On Oct 29, 2013 7:42 AM, "Rafael Espíndola" <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:<br>
><br>
> >  // Check fedora 18 on arm.<br>
> >  // RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \<br>
> >  // RUN:     --target=armv7-unknown-linux-gnueabihf \<br>
> >  // RUN:     --sysroot=%S/Inputs/fedora_18_tree \<br>
> >  // RUN:   | FileCheck --check-prefix=CHECK-FEDORA-18-ARM-HF %s<br>
> >  // CHECK-FEDORA-18-ARM-HF: "{{.*}}ld{{(.exe)?}}" "--sysroot=[[SYSROOT:[^"]+]]"<br>
> > -// CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../..{{/|\\\\}}crt1.o"<br>
> > -// CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../..{{/|\\\\}}crti.o"<br>
> > +// CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../../../lib{{/|\\\\}}crt1.o"<br>
> > +// CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../../../lib{{/|\\\\}}crti.o"<br>
> >  // CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2{{/|\\\\}}crtbegin.o"<br>
> >  // CHECK-FEDORA-18-ARM-HF: "-L[[SYSROOT]]/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2"<br>
> > -// CHECK-FEDORA-18-ARM-HF: "-L[[SYSROOT]]/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../.."<br>
> > +// CHECK-FEDORA-18-ARM-HF: "-L[[SYSROOT]]/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../../../lib"<br>
> >  // CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2{{/|\\\\}}crtend.o"<br>
> > -// CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../..{{/|\\\\}}crtn.o"<br>
> > +// CHECK-FEDORA-18-ARM-HF: "{{.*}}/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../../../lib{{/|\\\\}}crtn.o"<br>
><br>
> This is a regression. This patch is almost the same as Logan's<br>
> original patch (<a href="http://llvm-reviews.chandlerc.com/D2030">http://llvm-reviews.chandlerc.com/D2030</a>).<br>
><br>
> To avoid it is why I added the check for the distro. You kept saying<br>
> there was a better way to check it, but in the end you just changed<br>
> the test to register the regression without even asking for a review.<br>
><br>
> Gcc on fedora 18 arm uses 2 -L options:<br>
><br>
> -L/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2<br>
> -L/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../..<br>
><br>
> Before your patch clang would use<br>
><br>
> -L/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2<br>
> -L/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../..<br>
> -L/lib<br>
> -L/usr/lib<br>
><br>
> We now use<br>
><br>
> -L/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2<br>
> -L/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../../../lib<br>
> -L/lib/../lib<br>
> -L/usr/lib/../lib<br>
> -L/usr/lib/gcc/armv7hl-redhat-linux-gnueabi/4.7.2/../../..<br>
> -L/lib<br>
> -L/usr/lib<br>
><br>
> Which adds redundant -L lines and the redundant "../lib". Do you<br>
> actually have a plan to fix this?</p>
<p dir="ltr">Do these redundant search paths break fedora in any way?<br>
><br>
> Cheers,<br>
> Rafael<br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</p>