<div dir="ltr">Hah.  I guess I didn't observe it because we don't support pointers to members of virtual bases.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Oct 27, 2013 at 1:26 PM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">FYI<br>
<br>
2013/10/27 Timur Iskhodzhanov <<a href="mailto:timurrrr@google.com">timurrrr@google.com</a>>:<br>
<div class="HOEnZb"><div class="h5">> Author: timurrrr<br>
> Date: Sun Oct 27 12:10:27 2013<br>
> New Revision: 193505<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193505&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=193505&view=rev</a><br>
> Log:<br>
> Fix the inconsistent order of parameters in the GetVBaseOffsetFromVBPtr definition and declaration<br>
><br>
> Modified:<br>
>     cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp<br>
><br>
> Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp?rev=193505&r1=193504&r2=193505&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp?rev=193505&r1=193504&r2=193505&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp (original)<br>
> +++ cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp Sun Oct 27 12:10:27 2013<br>
> @@ -412,7 +412,7 @@ MicrosoftCXXABI::GetVirtualBaseClassOffs<br>
>      llvm::ConstantInt::get(CGM.IntTy, VBTableChars.getQuantity());<br>
><br>
>    llvm::Value *VBPtrToNewBase =<br>
> -    GetVBaseOffsetFromVBPtr(CGF, This, VBTableOffset, VBPtrOffset);<br>
> +    GetVBaseOffsetFromVBPtr(CGF, This, VBPtrOffset, VBTableOffset);<br>
>    VBPtrToNewBase =<br>
>      CGF.Builder.CreateSExtOrBitCast(VBPtrToNewBase, CGM.PtrDiffTy);<br>
>    return CGF.Builder.CreateNSWAdd(VBPtrOffset, VBPtrToNewBase);<br>
> @@ -1436,8 +1436,8 @@ bool MicrosoftCXXABI::MemberPointerConst<br>
>  llvm::Value *<br>
>  MicrosoftCXXABI::GetVBaseOffsetFromVBPtr(CodeGenFunction &CGF,<br>
>                                           llvm::Value *This,<br>
> -                                         llvm::Value *VBTableOffset,<br>
>                                           llvm::Value *VBPtrOffset,<br>
> +                                         llvm::Value *VBTableOffset,<br>
>                                           llvm::Value **VBPtrOut) {<br>
>    CGBuilderTy &Builder = CGF.Builder;<br>
>    // Load the vbtable pointer from the vbptr in the instance.<br>
> @@ -1493,7 +1493,7 @@ MicrosoftCXXABI::AdjustVirtualBase(CodeG<br>
>    }<br>
>    llvm::Value *VBPtr = 0;<br>
>    llvm::Value *VBaseOffs =<br>
> -    GetVBaseOffsetFromVBPtr(CGF, Base, VBTableOffset, VBPtrOffset, &VBPtr);<br>
> +    GetVBaseOffsetFromVBPtr(CGF, Base, VBPtrOffset, VBTableOffset, &VBPtr);<br>
>    llvm::Value *AdjustedBase = Builder.CreateInBoundsGEP(VBPtr, VBaseOffs);<br>
><br>
>    // Merge control flow with the case where we didn't have to adjust.<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>