<div dir="ltr"><div>Good catch!  This actually should have been tested years ago because it's never worked =)</div>Activated in revision 193664.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 29, 2013 at 4:57 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Tue, Oct 29, 2013 at 4:49 PM, Warren Hunt <span dir="ltr"><<a href="mailto:whunt@google.com" target="_blank">whunt@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: whunt<br>
Date: Tue Oct 29 18:49:26 2013<br>
New Revision: 193661<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193661&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=193661&view=rev</a><br>
Log:<br>
Fixing code gen to handle microsoft layouts for which size % alignment<br>
!= 0<br></blockquote><div><br></div></div><div>Test case?</div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp?rev=193661&r1=193660&r2=193661&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp?rev=193661&r1=193660&r2=193661&view=diff</a><br>


==============================================================================<br>
--- cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/CGRecordLayoutBuilder.cpp Tue Oct 29 18:49:26 2013<br>
@@ -203,6 +203,9 @@ public:<br>
 void CGRecordLayoutBuilder::Layout(const RecordDecl *D) {<br>
   Alignment = Types.getContext().getASTRecordLayout(D).getAlignment();<br>
   Packed = D->hasAttr<PackedAttr>();<br>
+  const ASTRecordLayout &Layout = Types.getContext().getASTRecordLayout(D);<br>
+  if (Layout.getSize() % Layout.getAlignment() != 0)<br>
+    Packed = true;<br>
<br>
   if (D->isUnion()) {<br>
     LayoutUnion(D);<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div><br></div></div>
</blockquote></div><br></div>