<div dir="ltr">LGTM</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 23, 2013 at 11:30 AM, Nick Lewycky <span dir="ltr"><<a href="mailto:nlewycky@google.com" target="_blank">nlewycky@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi kcc,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2004" target="_blank">http://llvm-reviews.chandlerc.com/D2004</a><br>
<br>
Files:<br>
lib/sanitizer_common/sanitizer_common.cc<br>
<br>
Index: lib/sanitizer_common/sanitizer_common.cc<br>
===================================================================<br>
--- lib/sanitizer_common/sanitizer_common.cc<br>
+++ lib/sanitizer_common/sanitizer_common.cc<br>
@@ -168,7 +168,8 @@<br>
const int kMaxSize = 1024; // We don't want a summary too long.<br>
InternalScopedBuffer<char> buff(kMaxSize);<br>
internal_snprintf(<br>
- buff.data(), kMaxSize, "%s: %s %s:%d %s", SanitizerToolName, error_type,<br>
+ buff.data(), kMaxSize, "SUMMARY: %s: %s %s:%d %s", SanitizerToolName,<br>
+ error_type,<br>
file ? StripPathPrefix(file, common_flags()->strip_path_prefix) : "??",<br>
line, function ? function : "??");<br>
__sanitizer_report_error_summary(buff.data());<br>
@@ -233,6 +234,6 @@<br>
}<br>
<br>
void __sanitizer_report_error_summary(const char *error_summary) {<br>
- Printf("SUMMARY: %s\n", error_summary);<br>
+ Printf("%s\n", error_summary);<br>
}<br>
} // extern "C"<br>
</blockquote></div><br></div>