<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 14, 2013 at 12:02 AM, Andy Gibbs <span dir="ltr"><<a href="mailto:andyg1001@hotmail.co.uk" target="_blank">andyg1001@hotmail.co.uk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: andyg<br>
Date: Mon Oct 14 02:02:04 2013<br>
New Revision: 192570<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=192570&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=192570&view=rev</a><br>
Log:<br>
Fixed "ArgSize may be used uninitialised" error when compiling with gcc.<br>
<br>
Modified:<br>
    cfe/trunk/lib/CodeGen/TargetInfo.cpp<br>
<br>
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/TargetInfo.cpp?rev=192570&r1=192569&r2=192570&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/TargetInfo.cpp?rev=192570&r1=192569&r2=192570&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/CodeGen/TargetInfo.cpp (original)<br>
+++ cfe/trunk/lib/CodeGen/TargetInfo.cpp Mon Oct 14 02:02:04 2013<br>
@@ -5444,7 +5444,7 @@ llvm::Value *XCoreABIInfo::EmitVAArg(llv<br>
     AI.setCoerceToType(ArgTy);<br>
   llvm::Type *ArgPtrTy = llvm::PointerType::getUnqual(ArgTy);<br>
   llvm::Value *Val;<br>
-  uint64_t ArgSize;<br>
+  uint64_t ArgSize = 0;<br></blockquote><div><br></div><div>Generally I believe we would prefer to disable the warning than needlessly initialize the variable (is this needless initialization? I haven't looked at the rest of the code, but I assume it is). That way dynamic tools (MSan, Valgrind, etc) can properly diagnose when the algorithm has bugs that fail to initialize this variable.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   switch (AI.getKind()) {<br>
   case ABIArgInfo::Expand:<br>
     llvm_unreachable("Unsupported ABI kind for va_arg");<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>