<p dir="ltr">Ha, I wondered if that would be the case. That parse error is also a bug.</p>
<div class="gmail_quote">On 10 Oct 2013 12:33, "Benjamin Kramer" <<a href="mailto:benny.kra@gmail.com">benny.kra@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On 10.10.2013, at 20:31, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:<br>
<br>
> What do we do in the corresponding case for constructors? It seems like we should handle those two cases together.<br>
<br>
We generate a parse error way before we get to the address operator:<br>
<br>
test.c:3:15: error: expected '(' for function-style cast or type construction<br>
auto a = &A::A;<br>
          ~~~~^<br>
<br>
- Ben<br>
<br>
> On 10 Oct 2013 02:49, "Benjamin Kramer" <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br>
> Author: d0k<br>
> Date: Thu Oct 10 04:44:41 2013<br>
> New Revision: 192345<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=192345&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=192345&view=rev</a><br>
> Log:<br>
> Sema: Taking the address of a dtor is illegal per C++ [class.dtor]p2.<br>
><br>
> Emit a proper error instead of crashing in CodeGen. PR16892.<br>
><br>
> Modified:<br>
>     cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
>     cfe/trunk/lib/Sema/SemaExpr.cpp<br>
>     cfe/trunk/test/SemaCXX/destructor.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=192345&r1=192344&r2=192345&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td?rev=192345&r1=192344&r2=192345&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td (original)<br>
> +++ cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td Thu Oct 10 04:44:41 2013<br>
> @@ -4483,6 +4483,8 @@ def ext_typecheck_addrof_temporary : Ext<br>
>    InGroup<DiagGroup<"address-of-temporary">>, DefaultError;<br>
>  def err_typecheck_addrof_temporary : Error<<br>
>    "taking the address of a temporary object of type %0">;<br>
> +def err_typecheck_addrof_dtor : Error<<br>
> +  "taking the address of a destructor">;<br>
>  def err_typecheck_unary_expr : Error<<br>
>    "invalid argument type %0 to unary expression">;<br>
>  def err_typecheck_indirection_requires_pointer : Error<<br>
><br>
> Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=192345&r1=192344&r2=192345&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=192345&r1=192344&r2=192345&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>
> +++ cfe/trunk/lib/Sema/SemaExpr.cpp Thu Oct 10 04:44:41 2013<br>
> @@ -8709,6 +8709,10 @@ QualType Sema::CheckAddressOfOperand(Exp<br>
>        }<br>
>      }<br>
><br>
> +    // Taking the address of a dtor is illegal per C++ [class.dtor]p2.<br>
> +    if (isa<CXXDestructorDecl>(MD))<br>
> +      Diag(OpLoc, diag::err_typecheck_addrof_dtor) << op->getSourceRange();<br>
> +<br>
>      return Context.getMemberPointerType(op->getType(),<br>
>                Context.getTypeDeclType(MD->getParent()).getTypePtr());<br>
>    } else if (lval != Expr::LV_Valid && lval != Expr::LV_IncompleteVoidType) {<br>
><br>
> Modified: cfe/trunk/test/SemaCXX/destructor.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/destructor.cpp?rev=192345&r1=192344&r2=192345&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/destructor.cpp?rev=192345&r1=192344&r2=192345&view=diff</a><br>

> ==============================================================================<br>
> --- cfe/trunk/test/SemaCXX/destructor.cpp (original)<br>
> +++ cfe/trunk/test/SemaCXX/destructor.cpp Thu Oct 10 04:44:41 2013<br>
> @@ -363,3 +363,7 @@ namespace PR7900 {<br>
>      (&b)->~A(); // expected-error{{destructor type 'PR7900::A' in object destruction expression does not match the type 'PR7900::B' of the object being destroyed}}<br>
>    }<br>
>  }<br>
> +<br>
> +namespace PR16892 {<br>
> +  auto p = &A::~A; // expected-error{{taking the address of a destructor}}<br>
> +}<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote></div>