<div dir="ltr"><div>Last version of patch was missing some makefile changes. I attached updated patch which now work also without cmake.<br></div><div><br></div><div>BR, Mikael</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Oct 9, 2013 at 8:42 PM, Mikael Lepistö <span dir="ltr"><<a href="mailto:mikael.lepisto@vincit.fi" target="_blank">mikael.lepisto@vincit.fi</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Hi, thanks for the comments!<div><br></div><div>I finally got time to update the patch on top of latest llvm-trunk revision 192297 and I removed the brackets as suggested. </div><div><br></div><div>Thanks, Mikael<br>
<div><br></div><div><br></div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 27, 2013 at 5:17 PM, Tom Stellard <span dir="ltr"><<a href="mailto:tom@stellard.net" target="_blank">tom@stellard.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Mikael,<br>
<br>
Sorry this patch fell through the cracks. You should take a look at<br>
some of the previous OpenCL patches that were submitted and cc the<br>
people who reviewed those patches and also the code owner listed in<br>
clang/CODE_OWNERS.txt.<br>
<br>
The only issue I see with the patch is the brackets around the if<br>
statement here:<br>
<br>
+<br>
+ if (PP.getPPCallbacks()) {<br>
+ PP.getPPCallbacks()->PragmaOpenCLExtension(NameLoc, ename,<br>
+ StateLoc, state);<br>
+ }<br>
}<br>
<br>
-Tom<br>
<div><div><br>
On Fri, Sep 27, 2013 at 11:13:23AM +0300, Mikael Lepistö wrote:<br>
> And here is also the patch file reattached from the original posting.<br>
><br>
> - Mikael<br>
><br>
><br>
> On Fri, Sep 27, 2013 at 10:35 AM, Mikael Lepistö<br>
> <<a href="mailto:mikael.lepisto@vincit.fi" target="_blank">mikael.lepisto@vincit.fi</a>>wrote:<br>
><br>
> > Hi, I submitted this patch ~20 days ago. Could this get some<br>
> > comments/review if the solution is acceptable or if there is some other<br>
> > preferred way to implement it?<br>
> ><br>
> > Thanks, Mikael<br>
> ><br>
> ><br>
> > On Mon, Sep 16, 2013 at 8:37 AM, Mikael Lepistö <<a href="mailto:mikael.lepisto@vincit.fi" target="_blank">mikael.lepisto@vincit.fi</a>>wrote:<br>
> ><br>
> >> Hi, ping<br>
> >><br>
> >> I sent this simple patch some time ago to list, but it got no responses.<br>
> >> Is there any estimates, when this might be reviewed or added to main repo?<br>
> >><br>
> >> Thanks, Mikael Lepistö<br>
> >><br>
> >><br>
> >> I also added missing [PATCH] tag to subject (I forgot to to put it to<br>
> >> original mail).<br>
> >><br>
> >> On Sat, Sep 7, 2013 at 12:49 PM, Mikael Lepistö <<a href="mailto:mikael.lepisto@vincit.fi" target="_blank">mikael.lepisto@vincit.fi</a><br>
> >> > wrote:<br>
> >><br>
> >>> Hi,<br>
> >>><br>
> >>> We needed in our project (<br>
> >>> <a href="https://github.com/KhronosGroup/webcl-validator" target="_blank">https://github.com/KhronosGroup/webcl-validator</a>) to be able to define<br>
> >>> callbacks for handling OpenCL extension pragmas to catch easily which<br>
> >>> OpenCL extensions are enabled/disabled.<br>
> >>><br>
> >>> I attached the patch file and test case for the functionality. Rami<br>
> >>> Ylimäki is actually author of the implementation I just wrote the test case<br>
> >>> and cleaned up the patch for upstreaming.<br>
> >>><br>
> >>> I had to add clangParse and clangSema libraries to PPCallbacksTest<br>
> >>> compilation, because enabling OpenCL support for preprocessor required<br>
> >>> Parser instance. Parser instance actually reads LangOptions from<br>
> >>> preprocessor and registers correct pragma handlers to preprocessor.<br>
> >>><br>
> >>> Any comments, improvements?<br>
> >>><br>
> >>> Cheers, Mikael Lepistö<br>
> >>><br>
> >>><br>
> >>><br>
> >><br>
> ><br>
<br>
<br>
</div></div>> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>