<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>OK, it’s reasonable.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>-Hao<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Kevin Qin [mailto:kevinqindev@gmail.com] <br><b>Sent:</b> Friday, October 11, 2013 2:50 AM<br><b>To:</b> Hao Liu<br><b>Cc:</b> Tim Northover; llvm-commits; cfe-commits@cs.uiuc.edu<br><b>Subject:</b> Re: [PATCH] Implement aarch64 neon instruction class SIMD copy - Clang<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Hi Hao,<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal><span style='font-size:10.5pt;font-family:"Arial","sans-serif"'>GenOpString() is only used to generate function body, but here I want to modified the function's argument name, like switching vcopy_lane(a, b, c) to vcopy_lane(a1, b1, c1).</span><o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>2013/10/10 Hao Liu <<a href="mailto:Hao.Liu@arm.com" target="_blank">Hao.Liu@arm.com</a>><o:p></o:p></p><p class=MsoNormal>Hi Kevin,<br><br>There are two points of hard code in shared functions:<br><br>+ //To avoid argument being multiple defined, add extra number for renaming.<br>+ if (name == "vcopy_lane")<br>+ s.push_back('1');<br><br>+ bool extranumber = false;<br>+ if(name == "vcopy_lane")<br>+ extranumber = true;<br><br> s += TypeString(proto[i], typestr) + " __";<br> s.push_back(arg);<br>+ if(extranumber)<br>+ s.push_back('1');<br> s += " = (";<br> s.push_back(arg);<br>+ if(extranumber)<br>+ s.push_back('1');<br><br><br>I think maybe this is not necessary. Because you can achieve renaming in function GenOpString(name, op, proto, typestr).<br>As this function has passed the "name", you can handle renaming under the switch case of OpCopy like:<br><br>case OpCopy: {<br> if (name == "vcopy_lane") {<br> renaming ....<o:p></o:p></p><div><div><p class=MsoNormal style='margin-bottom:12.0pt'> }<br> }<br><br>-----Original Message-----<br>From: <a href="mailto:cfe-commits-bounces@cs.uiuc.edu">cfe-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:cfe-commits-bounces@cs.uiuc.edu">cfe-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Kevin Qin<br>Sent: Tuesday, October 08, 2013 6:34 AM<br>To: <a href="mailto:kevinqindev@gmail.com">kevinqindev@gmail.com</a>; <a href="mailto:t.p.northover@gmail.com">t.p.northover@gmail.com</a><br>Cc: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>; <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>Subject: [PATCH] Implement aarch64 neon instruction class SIMD copy - Clang<br><br>Implemented related ACLE intrinsic : vget_lane, vset_lane, vcopy_lane, vcreate, vdup_n, vdup_lane, vmov_n<br><br>Please review, thanks.<br><br><a href="http://llvm-reviews.chandlerc.com/D1855" target="_blank">http://llvm-reviews.chandlerc.com/D1855</a><br><br>Files:<br> include/clang/Basic/<a href="http://arm_neon.td" target="_blank">arm_neon.td</a><br> lib/CodeGen/CGBuiltin.cpp<br> test/CodeGen/aarch64-neon-copy.c<br> utils/TableGen/NeonEmitter.cpp<br><br><o:p></o:p></p></div></div></div><p class=MsoNormal><br><br clear=all><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal>-- <o:p></o:p></p><div><p class=MsoNormal>Best Regards,<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Kevin Qin<o:p></o:p></p></div></div></div></div></body></html>