<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Reid,<div><br><div><div>On Oct 10, 2013, at 10:13 AM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Do you intend to use the accessor elsewhere? For the one use of the accessor in the static helper function, maybe it's better to pass CGM into it and then delete the accessor?<div><br></div></div></blockquote><div><br></div><div>Thanks for taking a look. </div><div><br></div><div>The patch I sent out more recently to decouple the creation of CodeGenModule and CodeGenTypes removes CGM from CodeGenTypes and adds a TargetCodegenInfo* directly to CodeGenTypes, so this code becomes CGT.getTargetCodeGenInfo()….</div><div><br></div><div>I don’t think anybody has had a chance to take a close look at that patch yet, so I’ll do as you suggest for now and just pass a CGM& in directly from the two call sites to this function.</div><div><br></div><div>Mark</div><div><br></div><br><blockquote type="cite"><div dir="ltr"><div>Either way the privatizing looks good.</div></div></blockquote><div><br></div><blockquote type="cite"><div dir="ltr">
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Oct 3, 2013 at 2:26 PM, Mark Lacey <span dir="ltr"><<a href="mailto:mark.lacey@apple.com" target="_blank">mark.lacey@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;"><br>
Add an accessor for the CodeGenModule reference stored in CodeGenTypes.<br>
<br>
No functionality differences.<br>
---<br>
lib/CodeGen/CGCall.cpp | 2 +-<br>
lib/CodeGen/CodeGenTypes.h | 5 ++---<br>
2 files changed, 3 insertions(+), 4 deletions(-)<br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></body></html>