<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Thanks for testing. Can someone with commit permissions apply
the patch, please?<br>
<br>
Thanks!<br>
Vladimir.<br>
<br>
</tt>
<div class="moz-cite-prefix">On 10/ 7/13 06:55 PM, Rafael Espíndola
wrote:<br>
</div>
<blockquote
cite="mid:CAG3jReL6gj1W-x-wzpKPNc+G2Ke0FLcKW3d_ovXt8uid9veyBg@mail.gmail.com"
type="cite">
<pre wrap="">I tested that the attached patch works on linux.
On 7 October 2013 08:57, Vladimir Voskresensky - Oracle
<a class="moz-txt-link-rfc2396E" href="mailto:vladimir.voskresensky@oracle.com"><vladimir.voskresensky@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I tried to be as safe as possible.
Could you, please, check on non Solaris system, that it works without #ifdef
__sun__.
Thanks,
Vladimir.
On 10/ 7/13 04:39 PM, Rafael Espíndola wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
On 7 October 2013 07:09, Vladimir Voskresensky - Oracle
<a class="moz-txt-link-rfc2396E" href="mailto:vladimir.voskresensky@oracle.com"><vladimir.voskresensky@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
when build sources as is with gcc 4.6.3 the first error is:
----------
In file included from
/export/devarea/LLVM/llvm/lib/Support/Path.cpp:1020:0:
/export/devarea/LLVM/llvm/lib/Support/Unix/Path.inc: In function
‘std::string llvm::sys::fs::getMainExecutable(const char*, void*)’:
/export/devarea/LLVM/llvm/lib/Support/Unix/Path.inc:274:3: error:
‘Dl_info’
was not declared in this scope
/export/devarea/LLVM/llvm/lib/Support/Unix/Path.inc:274:11: error:
expected
‘;’ before ‘DLInfo’
/export/devarea/LLVM/llvm/lib/Support/Unix/Path.inc:275:31: error:
‘DLInfo’
was not declared in this scope
/export/devarea/LLVM/llvm/lib/Support/Unix/Path.inc:275:37: error:
‘dladdr’
was not declared in this scope
----------
</pre>
</blockquote>
<pre wrap="">
We can drop the #ifdef __sun__, no? It should always be safe to
include dlfcn.h if HAVE_DLFCN_H is defined.
</pre>
<blockquote type="cite">
<pre wrap="">after applying fix for Unix.h the next error is:
----------
In file included from
/export/devarea/LLVM/llvm/lib/Support/Unix/Program.inc:39:0,
from
/export/devarea/LLVM/llvm/lib/Support/Program.cpp:63:
/usr/include/spawn.h:52:14: error: expected ‘,’ or ‘...’ before ‘argv’
/usr/include/spawn.h:60:14: error: expected ‘,’ or ‘...’ before ‘argv’
In file included from
/export/devarea/LLVM/llvm/lib/Support/Program.cpp:63:0:
/export/devarea/LLVM/llvm/lib/Support/Unix/Program.inc: In function ‘bool
Execute(llvm::sys::ProcessInfo&, llvm::StringRef, const char**, const
char**, const llvm::StringRef**, unsigned int, std::string*)’:
/export/devarea/LLVM/llvm/lib/Support/Unix/Program.inc:243:79: error:
cannot
convert ‘char**’ to ‘char*’ for argument ‘5’ to ‘int posix_spawn(pid_t*,
const char*, const posix_spawn_file_actions_t*, const posix_spawnattr_t*,
char*)’
----------
This one is fixed by patching Program.inc
</pre>
</blockquote>
<pre wrap="">
Because gcc doesn't understand the restrict keyword?
In any case, patch LGTM with the #ifdef __sun__ dropped.
Cheers,
Rafael
</pre>
</blockquote>
<pre wrap="">
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
cfe-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a>
</pre>
</blockquote>
</blockquote>
<br>
</body>
</html>