<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Hi Che-Liang,</div><br><div><div>On Oct 4, 2013, at 9:53 PM, Che-Liang Chiou <<a href="mailto:clchiou@gmail.com">clchiou@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">This patch exposes ref-qualifier information of function type.<br><span><refqualifier.patch></span></blockquote></div><div><br></div><div><div>+enum CXRefQualifierKind {</div><div>+ /** \brief No ref-qualifier was provided. */</div><div>+ CXRQ_None = 0,</div><div>+ /** \brief An lvalue ref-qualifier was provided (\c &). */</div><div>+ CXRQ_LValue,</div><div>+ /** \brief An rvalue ref-qualifier was provided (\c &&). */</div><div>+ CXRQ_RValue</div><div>+};</div></div><div><br></div><div>The general convention used is to repeat the enumerator name without 'kind' in the enumerators:</div><div><br></div><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;"><div><div><div>enum CXRefQualifierKind {</div></div></div><div><div> /** \brief No ref-qualifier was provided. */</div></div><div><div> CXRefQualifier_None = 0,</div></div><div><div> /** \brief An lvalue ref-qualifier was provided (\c &). */</div></div><div><div> CXRefQualifier_LValue,</div></div><div><div> /** \brief An rvalue ref-qualifier was provided (\c &&). */</div></div><div><div> CXRefQualifier_RValue</div></div><div><div>};</div></div></blockquote><div><br></div><div><br></div><div><br></div><div>+ * \brief Retrieve the ref-qualifier kind of a function or method.</div><div><div>+ *</div><div>+ * The ref-qualifier is returned for functions or methods. For other types</div><div>+ * CXRQ_None is returned.</div><div>+ */</div><div>+CINDEX_LINKAGE enum CXRefQualifierKind clang_Type_getRefQualifier(CXType T);</div></div><div><br></div><div>Could you rename it to clang_Type_getCXXRefQualifier and mention in the comments that this is only relevant for C++ ?</div><div><br></div><div>Finally, could you also add some tests for this ?</div><div><br></div></body></html>