<div dir="ltr">Is it possible to write a test for this?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 7, 2013 at 12:33 AM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: majnemer<br>
Date: Mon Oct  7 02:33:27 2013<br>
New Revision: 192091<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=192091&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=192091&view=rev</a><br>
Log:<br>
Driver: Use the canonical command line arguments.<br>
<br>
Summary:<br>
Use the arguments given to the OS at process creation-time instead of<br>
the arguments passed into main() by the C runtime environment.  The ones<br>
that main() received may not be suitable (e.g. not Unicode).<br>
<br>
Depends on D1834<br>
<br>
CC: cfe-commits<br>
<br>
Differential Revision: <a href="http://llvm-reviews.chandlerc.com/D1835" target="_blank">http://llvm-reviews.chandlerc.com/D1835</a><br>
<br>
Modified:<br>
    cfe/trunk/tools/driver/driver.cpp<br>
<br>
Modified: cfe/trunk/tools/driver/driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/driver.cpp?rev=192091&r1=192090&r2=192091&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/driver.cpp?rev=192091&r1=192090&r2=192091&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/tools/driver/driver.cpp (original)<br>
+++ cfe/trunk/tools/driver/driver.cpp Mon Oct  7 02:33:27 2013<br>
@@ -37,6 +37,7 @@<br>
 #include "llvm/Support/MemoryBuffer.h"<br>
 #include "llvm/Support/Path.h"<br>
 #include "llvm/Support/PrettyStackTrace.h"<br>
+#include "llvm/Support/Process.h"<br>
 #include "llvm/Support/Program.h"<br>
 #include "llvm/Support/Regex.h"<br>
 #include "llvm/Support/Signals.h"<br>
@@ -292,8 +293,16 @@ int main(int argc_, const char **argv_)<br>
   llvm::sys::PrintStackTraceOnErrorSignal();<br>
   llvm::PrettyStackTraceProgram X(argc_, argv_);<br>
<br>
+  SmallVector<const char *, 256> argv;<br>
+  llvm::SpecificBumpPtrAllocator<char> ArgAllocator;<br>
+  llvm::error_code EC = llvm::sys::Process::GetArgumentVector(<br>
+      argv, llvm::ArrayRef<const char *>(argv_, argc_), ArgAllocator);<br>
+  if (EC) {<br>
+    llvm::errs() << "error: couldn't get arguments: " << EC.message() << '\n';<br>
+    return 1;<br>
+  }<br>
+<br>
   std::set<std::string> SavedStrings;<br>
-  SmallVector<const char*, 256> argv(argv_, argv_ + argc_);<br>
   StringSetSaver Saver(SavedStrings);<br>
   llvm::cl::ExpandResponseFiles(Saver, llvm::cl::TokenizeGNUCommandLine, argv);<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>