<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Adding these should come after checking IgnoredOptionMap since some options need to be ignored.<div><div> # Ignored options.</div><div> if (defined $IgnoredOptionMap{$ArgKey}) {</div><div> my $Cnt = $IgnoredOptionMap{$ArgKey};</div><div> while ($Cnt > 0) {</div><div> ++$i; --$Cnt;</div><div> }</div><div> next;</div><div> }</div><div><br></div><div>Also, I would have thought that the following would add the valid -f options to the command line. Why that does not work?</div><div><br></div><div><div> if ($Arg =~ /^-f/) {</div><div> push @CompileOpts,$Arg;</div><div> push @LinkOpts,$Arg;</div><div> next;</div><div> }</div></div><div><br></div><div>Thanks,</div><div>Anna.</div><div><div>On Oct 1, 2013, at 11:32 PM, Liang Qi <<a href="mailto:cavendish.qi@gmail.com">cavendish.qi@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Hi,</div><div><br></div><div>This change whitelists -fXXXX options. At least the use case here is to pass -fPIE and -fPIC to compiler, more talks in <a href="https://bugreports.qt-project.org/browse/QTBUG-33698">https://bugreports.qt-project.org/browse/QTBUG-33698</a> .</div>
<div><br></div><div>Review appreciated.</div><div><br></div><div>Regards,</div><div>Liang</div><div><br></div><div><div id=":33l" class="" style="font-size:13.333333969116211px;margin-bottom:0px;margin-left:0px;padding-bottom:5px;font-family:arial,sans-serif">
<div id=":126" style="overflow:hidden"><a href="http://llvm-reviews.chandlerc.com/D1805" target="_blank">http://llvm-reviews.chandlerc.com/D1805</a><br><br>Files:<br> tools/scan-build/ccc-analyzer<br><br>Index: tools/scan-build/ccc-analyzer<br>
===================================================================<br>--- tools/scan-build/ccc-analyzer<br>+++ tools/scan-build/ccc-analyzer<br>@@ -488,6 +488,10 @@<br> push @CompileOpts,$Arg;<br> next;<br> }<br>
+ if ($Arg =~ /-f.*/) {<br>+ push @CompileOpts,$Arg;<br>+ next;<br>+ }<br> # Handle the case where there isn't a space after -iquote<br> if ($Arg =~ /-iquote.*/) {<br> push @CompileOpts,$Arg;<div class="">
</div></div></div><div id=":43b" class="" style="font-size:13.333333969116211px;font-family:arial,sans-serif"></div></div><div><br></div><br></div>
_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits<br></blockquote></div><br></div></body></html>