<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 1, 2013 at 4:07 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">>> > I also observed 1% to 2% performance improvement on some benchmarks.<br>
>> ><br>
>><br>
>> Could you show these numbers? Keep in mind that turning other such<br>
>> things on by default has usually been shown with real numbers and<br>
>> tested more widely - or at least discussion.<br>
><br>
><br>
> 1st number: the percentage of execution time change, 2nd number: base<br>
> execution time (without struct-path aware TBAA):<br>
> MultiSource/Benchmarks/MiBench/telecomm-CRC32/telecomm-CRC32<br>
> -2.92304043638 1.6866<br>
> External/SPEC/CFP2006/433.milc/433.milc<br>
> -2.54741997653 6.9011<br>
> External/SPEC/CINT2000/255.vortex/255.vortex<br>
> -2.33475411922 1.5719<br>
> External/SPEC/CINT2006/400.perlbench/400.perlbench<br>
> -2.1423993236 7.3329<br>
><br>
<br>
</div>Missing some numbers here, but...<br>
Are these the only numbers that changed outside of noise? Were there<br>
any regressions?<br></blockquote><div>Yes, the above numbers are ones that I think are outside of noise. I didn't</div><div>notice any regression outside of noise.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
> Keep in mind that the above numbers were collected on my local machine.<br>
><br>
> We also did a lot of internal functional testing.<br>
<br>
</div>Heh. I doubt this will fire much with Objective-C ;)<br>
<br>
At any rate, how do the reversions of yesterday affect this patch?<br></blockquote><div>I am waiting for a reduced testing case from Richard, the crash happened with relaxed aliasing.</div><div><br></div><div>I probably made an assumption which is not true for relaxed aliasing, I believe the fix should be pretty</div>
<div>straight-forward and should not affect TBAA performance :)</div><div><br></div><div>Manman </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
-eric<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> Thanks,<br>
> Manman<br>
><br>
>><br>
>><br>
>> -eric<br>
>><br>
>><br>
>><br>
>> > Manman<br>
>> ><br>
>> ><br>
>> > On Mon, Sep 30, 2013 at 9:49 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Do you have any numbers or anything showing this as being a win?<br>
>> >><br>
>> >> -eric<br>
>> >><br>
>> >> On Mon, Sep 30, 2013 at 12:35 PM, Manman Ren <<a href="mailto:manman.ren@gmail.com">manman.ren@gmail.com</a>><br>
>> >> wrote:<br>
>> >> > Author: mren<br>
>> >> > Date: Mon Sep 30 14:35:19 2013<br>
>> >> > New Revision: 191695<br>
>> >> ><br>
>> >> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=191695&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=191695&view=rev</a><br>
>> >> > Log:<br>
>> >> > Turn struct-path aware TBAA on by default.<br>
>> >> ><br>
>> >> > Use -no-struct-path-tbaa to turn it off.<br>
>> >> ><br>
>> >> > Modified:<br>
>> >> > cfe/trunk/include/clang/Driver/CC1Options.td<br>
>> >> > cfe/trunk/include/clang/Driver/Options.td<br>
>> >> > cfe/trunk/lib/Driver/Tools.cpp<br>
>> >> > cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
>> >> > cfe/trunk/test/CodeGen/bitfield.c<br>
>> >> > cfe/trunk/test/CodeGen/may-alias.c<br>
>> >> > cfe/trunk/test/CodeGen/tbaa-class.cpp<br>
>> >> > cfe/trunk/test/CodeGen/tbaa.cpp<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/include/clang/Driver/CC1Options.td<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/include/clang/Driver/CC1Options.td (original)<br>
>> >> > +++ cfe/trunk/include/clang/Driver/CC1Options.td Mon Sep 30 14:35:19<br>
>> >> > 2013<br>
>> >> > @@ -165,8 +165,8 @@ def fuse_register_sized_bitfield_access:<br>
>> >> > HelpText<"Use register sized accesses to bit-fields, when<br>
>> >> > possible.">;<br>
>> >> > def relaxed_aliasing : Flag<["-"], "relaxed-aliasing">,<br>
>> >> > HelpText<"Turn off Type Based Alias Analysis">;<br>
>> >> > -def struct_path_tbaa : Flag<["-"], "struct-path-tbaa">,<br>
>> >> > - HelpText<"Turn on struct-path aware Type Based Alias Analysis">;<br>
>> >> > +def no_struct_path_tbaa : Flag<["-"], "no-struct-path-tbaa">,<br>
>> >> > + HelpText<"Turn off struct-path aware Type Based Alias Analysis">;<br>
>> >> > def masm_verbose : Flag<["-"], "masm-verbose">,<br>
>> >> > HelpText<"Generate verbose assembly output">;<br>
>> >> > def mcode_model : Separate<["-"], "mcode-model">,<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/include/clang/Driver/Options.td<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/include/clang/Driver/Options.td (original)<br>
>> >> > +++ cfe/trunk/include/clang/Driver/Options.td Mon Sep 30 14:35:19<br>
>> >> > 2013<br>
>> >> > @@ -646,6 +646,7 @@ def fno_spell_checking : Flag<["-"], "fn<br>
>> >> > def fno_stack_protector : Flag<["-"], "fno-stack-protector">,<br>
>> >> > Group<f_Group>;<br>
>> >> > def fno_strict_aliasing : Flag<["-"], "fno-strict-aliasing">,<br>
>> >> > Group<f_Group>;<br>
>> >> > def fstruct_path_tbaa : Flag<["-"], "fstruct-path-tbaa">,<br>
>> >> > Group<f_Group>;<br>
>> >> > +def fno_struct_path_tbaa : Flag<["-"], "fno-struct-path-tbaa">,<br>
>> >> > Group<f_Group>;<br>
>> >> > def fno_strict_enums : Flag<["-"], "fno-strict-enums">,<br>
>> >> > Group<f_Group>;<br>
>> >> > def fno_strict_overflow : Flag<["-"], "fno-strict-overflow">,<br>
>> >> > Group<f_Group>;<br>
>> >> > def fno_threadsafe_statics : Flag<["-"], "fno-threadsafe-statics">,<br>
>> >> > Group<f_Group>,<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
>> >> > +++ cfe/trunk/lib/Driver/Tools.cpp Mon Sep 30 14:35:19 2013<br>
>> >> > @@ -2183,8 +2183,9 @@ void Clang::ConstructJob(Compilation &C,<br>
>> >> > options::OPT_fno_strict_aliasing,<br>
>> >> > getToolChain().IsStrictAliasingDefault()))<br>
>> >> > CmdArgs.push_back("-relaxed-aliasing");<br>
>> >> > - if (Args.hasArg(options::OPT_fstruct_path_tbaa))<br>
>> >> > - CmdArgs.push_back("-struct-path-tbaa");<br>
>> >> > + if (!Args.hasFlag(options::OPT_fstruct_path_tbaa,<br>
>> >> > + options::OPT_fno_struct_path_tbaa))<br>
>> >> > + CmdArgs.push_back("-no-struct-path-tbaa");<br>
>> >> > if (Args.hasFlag(options::OPT_fstrict_enums,<br>
>> >> > options::OPT_fno_strict_enums,<br>
>> >> > false))<br>
>> >> > CmdArgs.push_back("-fstrict-enums");<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/lib/Frontend/CompilerInvocation.cpp (original)<br>
>> >> > +++ cfe/trunk/lib/Frontend/CompilerInvocation.cpp Mon Sep 30 14:35:19<br>
>> >> > 2013<br>
>> >> > @@ -344,7 +344,7 @@ static bool ParseCodeGenArgs(CodeGenOpti<br>
>> >> > Opts.UseRegisterSizedBitfieldAccess = Args.hasArg(<br>
>> >> > OPT_fuse_register_sized_bitfield_access);<br>
>> >> > Opts.RelaxedAliasing = Args.hasArg(OPT_relaxed_aliasing);<br>
>> >> > - Opts.StructPathTBAA = Args.hasArg(OPT_struct_path_tbaa);<br>
>> >> > + Opts.StructPathTBAA = !Args.hasArg(OPT_no_struct_path_tbaa);<br>
>> >> > Opts.DwarfDebugFlags =<br>
>> >> > Args.getLastArgValue(OPT_dwarf_debug_flags);<br>
>> >> > Opts.MergeAllConstants =<br>
>> >> > !Args.hasArg(OPT_fno_merge_all_constants);<br>
>> >> > Opts.NoCommon = Args.hasArg(OPT_fno_common);<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/test/CodeGen/bitfield.c<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/bitfield.c?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/bitfield.c?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/test/CodeGen/bitfield.c (original)<br>
>> >> > +++ cfe/trunk/test/CodeGen/bitfield.c Mon Sep 30 14:35:19 2013<br>
>> >> > @@ -1,5 +1,5 @@<br>
>> >> > -// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o -<br>
>> >> > -O3<br>
>> >> > | FileCheck %s<br>
>> >> > -// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o -<br>
>> >> > -O3<br>
>> >> > -struct-path-tbaa | FileCheck %s --check-prefix=PATH<br>
>> >> > +// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o -<br>
>> >> > -O3<br>
>> >> > -no-struct-path-tbaa | FileCheck %s<br>
>> >> > +// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o -<br>
>> >> > -O3<br>
>> >> > | FileCheck %s --check-prefix=PATH<br>
>> >> ><br>
>> >> > static int f0(int n) {<br>
>> >> > struct s0 {<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/test/CodeGen/may-alias.c<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/may-alias.c?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/may-alias.c?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/test/CodeGen/may-alias.c (original)<br>
>> >> > +++ cfe/trunk/test/CodeGen/may-alias.c Mon Sep 30 14:35:19 2013<br>
>> >> > @@ -1,5 +1,5 @@<br>
>> >> > -// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm<br>
>> >> > -O1<br>
>> >> > -disable-llvm-optzns -o - %s | FileCheck %s<br>
>> >> > -// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm<br>
>> >> > -O1<br>
>> >> > -struct-path-tbaa -disable-llvm-optzns -o - %s | FileCheck %s<br>
>> >> > -check-prefix=PATH<br>
>> >> > +// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm<br>
>> >> > -O1<br>
>> >> > -no-struct-path-tbaa -disable-llvm-optzns -o - %s | FileCheck %s<br>
>> >> > +// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm<br>
>> >> > -O1<br>
>> >> > -disable-llvm-optzns -o - %s | FileCheck %s -check-prefix=PATH<br>
>> >> ><br>
>> >> > // Types with the may_alias attribute should be considered<br>
>> >> > equivalent<br>
>> >> > // to char for aliasing.<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/test/CodeGen/tbaa-class.cpp<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa-class.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa-class.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/test/CodeGen/tbaa-class.cpp (original)<br>
>> >> > +++ cfe/trunk/test/CodeGen/tbaa-class.cpp Mon Sep 30 14:35:19 2013<br>
>> >> > @@ -1,5 +1,5 @@<br>
>> >> > -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1<br>
>> >> > -disable-llvm-optzns<br>
>> >> > %s -emit-llvm -o - | FileCheck %s<br>
>> >> > -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -struct-path-tbaa<br>
>> >> > -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
>> >> > -check-prefix=PATH<br>
>> >> > +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1<br>
>> >> > -no-struct-path-tbaa<br>
>> >> > -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
>> >> > +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1<br>
>> >> > -disable-llvm-optzns<br>
>> >> > %s -emit-llvm -o - | FileCheck %s -check-prefix=PATH<br>
>> >> > // Test TBAA metadata generated by front-end.<br>
>> >> ><br>
>> >> > typedef unsigned char uint8_t;<br>
>> >> ><br>
>> >> > Modified: cfe/trunk/test/CodeGen/tbaa.cpp<br>
>> >> > URL:<br>
>> >> ><br>
>> >> > <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
>> >> ><br>
>> >> ><br>
>> >> > ==============================================================================<br>
>> >> > --- cfe/trunk/test/CodeGen/tbaa.cpp (original)<br>
>> >> > +++ cfe/trunk/test/CodeGen/tbaa.cpp Mon Sep 30 14:35:19 2013<br>
>> >> > @@ -1,5 +1,5 @@<br>
>> >> > -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1<br>
>> >> > -disable-llvm-optzns<br>
>> >> > %s -emit-llvm -o - | FileCheck %s<br>
>> >> > -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -struct-path-tbaa<br>
>> >> > -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
>> >> > -check-prefix=PATH<br>
>> >> > +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1<br>
>> >> > -no-struct-path-tbaa<br>
>> >> > -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
>> >> > +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1<br>
>> >> > -disable-llvm-optzns<br>
>> >> > %s -emit-llvm -o - | FileCheck %s -check-prefix=PATH<br>
>> >> > // Test TBAA metadata generated by front-end.<br>
>> >> ><br>
>> >> > typedef unsigned char uint8_t;<br>
>> >> ><br>
>> >> ><br>
>> >> > _______________________________________________<br>
>> >> > cfe-commits mailing list<br>
>> >> > <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
>> >> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
>> ><br>
>> ><br>
><br>
><br>
</div></div></blockquote></div><br></div></div>