<div dir="ltr"><br><div>This is an incremental step on top of scalar TBAA.</div><div><br></div><div>I collected stats when building SPEC targeting x86:</div><div>First number is without struct-path aware TBAA, the second number is with, the third number is the difference.<br>
</div><div><br></div><div><div>GVN_blocks_merged 398 405 7</div><div>GVN_equalities_propagated 10759 10813 54</div><div>GVN_instructions_PRE 2967 2911 -56</div>
<div>GVN_instructions_deleted 261595 265409 3814</div><div>GVN_instructions_simplified 70826 71195 369</div><div>GVN_loads_PRE 20444 20677 233</div><div>GVN_loads_deleted 76842 79041 2199</div>
<div>LICM_instructions_hoisted 114225 115546 1321</div><div>LICM_instructions_sunk 5 17 12</div><div>LICM_load_insts_hoisted_or_sunk 21430 22070 640</div><div>LICM_memory_locations_promoted 74 85 11</div>
</div><div><br></div><div>I also observed 1% to 2% performance improvement on some benchmarks.</div><div> </div><div>Manman</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 30, 2013 at 9:49 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Do you have any numbers or anything showing this as being a win?<br>
<span class="HOEnZb"><font color="#888888"><br>
-eric<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Mon, Sep 30, 2013 at 12:35 PM, Manman Ren <<a href="mailto:manman.ren@gmail.com">manman.ren@gmail.com</a>> wrote:<br>
> Author: mren<br>
> Date: Mon Sep 30 14:35:19 2013<br>
> New Revision: 191695<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=191695&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=191695&view=rev</a><br>
> Log:<br>
> Turn struct-path aware TBAA on by default.<br>
><br>
> Use -no-struct-path-tbaa to turn it off.<br>
><br>
> Modified:<br>
> cfe/trunk/include/clang/Driver/CC1Options.td<br>
> cfe/trunk/include/clang/Driver/Options.td<br>
> cfe/trunk/lib/Driver/Tools.cpp<br>
> cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
> cfe/trunk/test/CodeGen/bitfield.c<br>
> cfe/trunk/test/CodeGen/may-alias.c<br>
> cfe/trunk/test/CodeGen/tbaa-class.cpp<br>
> cfe/trunk/test/CodeGen/tbaa.cpp<br>
><br>
> Modified: cfe/trunk/include/clang/Driver/CC1Options.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/CC1Options.td?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Driver/CC1Options.td (original)<br>
> +++ cfe/trunk/include/clang/Driver/CC1Options.td Mon Sep 30 14:35:19 2013<br>
> @@ -165,8 +165,8 @@ def fuse_register_sized_bitfield_access:<br>
> HelpText<"Use register sized accesses to bit-fields, when possible.">;<br>
> def relaxed_aliasing : Flag<["-"], "relaxed-aliasing">,<br>
> HelpText<"Turn off Type Based Alias Analysis">;<br>
> -def struct_path_tbaa : Flag<["-"], "struct-path-tbaa">,<br>
> - HelpText<"Turn on struct-path aware Type Based Alias Analysis">;<br>
> +def no_struct_path_tbaa : Flag<["-"], "no-struct-path-tbaa">,<br>
> + HelpText<"Turn off struct-path aware Type Based Alias Analysis">;<br>
> def masm_verbose : Flag<["-"], "masm-verbose">,<br>
> HelpText<"Generate verbose assembly output">;<br>
> def mcode_model : Separate<["-"], "mcode-model">,<br>
><br>
> Modified: cfe/trunk/include/clang/Driver/Options.td<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/include/clang/Driver/Options.td (original)<br>
> +++ cfe/trunk/include/clang/Driver/Options.td Mon Sep 30 14:35:19 2013<br>
> @@ -646,6 +646,7 @@ def fno_spell_checking : Flag<["-"], "fn<br>
> def fno_stack_protector : Flag<["-"], "fno-stack-protector">, Group<f_Group>;<br>
> def fno_strict_aliasing : Flag<["-"], "fno-strict-aliasing">, Group<f_Group>;<br>
> def fstruct_path_tbaa : Flag<["-"], "fstruct-path-tbaa">, Group<f_Group>;<br>
> +def fno_struct_path_tbaa : Flag<["-"], "fno-struct-path-tbaa">, Group<f_Group>;<br>
> def fno_strict_enums : Flag<["-"], "fno-strict-enums">, Group<f_Group>;<br>
> def fno_strict_overflow : Flag<["-"], "fno-strict-overflow">, Group<f_Group>;<br>
> def fno_threadsafe_statics : Flag<["-"], "fno-threadsafe-statics">, Group<f_Group>,<br>
><br>
> Modified: cfe/trunk/lib/Driver/Tools.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Driver/Tools.cpp (original)<br>
> +++ cfe/trunk/lib/Driver/Tools.cpp Mon Sep 30 14:35:19 2013<br>
> @@ -2183,8 +2183,9 @@ void Clang::ConstructJob(Compilation &C,<br>
> options::OPT_fno_strict_aliasing,<br>
> getToolChain().IsStrictAliasingDefault()))<br>
> CmdArgs.push_back("-relaxed-aliasing");<br>
> - if (Args.hasArg(options::OPT_fstruct_path_tbaa))<br>
> - CmdArgs.push_back("-struct-path-tbaa");<br>
> + if (!Args.hasFlag(options::OPT_fstruct_path_tbaa,<br>
> + options::OPT_fno_struct_path_tbaa))<br>
> + CmdArgs.push_back("-no-struct-path-tbaa");<br>
> if (Args.hasFlag(options::OPT_fstrict_enums, options::OPT_fno_strict_enums,<br>
> false))<br>
> CmdArgs.push_back("-fstrict-enums");<br>
><br>
> Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/CompilerInvocation.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/lib/Frontend/CompilerInvocation.cpp (original)<br>
> +++ cfe/trunk/lib/Frontend/CompilerInvocation.cpp Mon Sep 30 14:35:19 2013<br>
> @@ -344,7 +344,7 @@ static bool ParseCodeGenArgs(CodeGenOpti<br>
> Opts.UseRegisterSizedBitfieldAccess = Args.hasArg(<br>
> OPT_fuse_register_sized_bitfield_access);<br>
> Opts.RelaxedAliasing = Args.hasArg(OPT_relaxed_aliasing);<br>
> - Opts.StructPathTBAA = Args.hasArg(OPT_struct_path_tbaa);<br>
> + Opts.StructPathTBAA = !Args.hasArg(OPT_no_struct_path_tbaa);<br>
> Opts.DwarfDebugFlags = Args.getLastArgValue(OPT_dwarf_debug_flags);<br>
> Opts.MergeAllConstants = !Args.hasArg(OPT_fno_merge_all_constants);<br>
> Opts.NoCommon = Args.hasArg(OPT_fno_common);<br>
><br>
> Modified: cfe/trunk/test/CodeGen/bitfield.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/bitfield.c?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/bitfield.c?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/bitfield.c (original)<br>
> +++ cfe/trunk/test/CodeGen/bitfield.c Mon Sep 30 14:35:19 2013<br>
> @@ -1,5 +1,5 @@<br>
> -// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o - -O3 | FileCheck %s<br>
> -// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o - -O3 -struct-path-tbaa | FileCheck %s --check-prefix=PATH<br>
> +// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o - -O3 -no-struct-path-tbaa | FileCheck %s<br>
> +// RUN: %clang_cc1 -triple i386-unknown-unknown %s -emit-llvm -o - -O3 | FileCheck %s --check-prefix=PATH<br>
><br>
> static int f0(int n) {<br>
> struct s0 {<br>
><br>
> Modified: cfe/trunk/test/CodeGen/may-alias.c<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/may-alias.c?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/may-alias.c?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/may-alias.c (original)<br>
> +++ cfe/trunk/test/CodeGen/may-alias.c Mon Sep 30 14:35:19 2013<br>
> @@ -1,5 +1,5 @@<br>
> -// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm -O1 -disable-llvm-optzns -o - %s | FileCheck %s<br>
> -// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm -O1 -struct-path-tbaa -disable-llvm-optzns -o - %s | FileCheck %s -check-prefix=PATH<br>
> +// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm -O1 -no-struct-path-tbaa -disable-llvm-optzns -o - %s | FileCheck %s<br>
> +// RUN: %clang_cc1 -Werror -triple i386-unknown-unknown -emit-llvm -O1 -disable-llvm-optzns -o - %s | FileCheck %s -check-prefix=PATH<br>
><br>
> // Types with the may_alias attribute should be considered equivalent<br>
> // to char for aliasing.<br>
><br>
> Modified: cfe/trunk/test/CodeGen/tbaa-class.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa-class.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa-class.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/tbaa-class.cpp (original)<br>
> +++ cfe/trunk/test/CodeGen/tbaa-class.cpp Mon Sep 30 14:35:19 2013<br>
> @@ -1,5 +1,5 @@<br>
> -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
> -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -struct-path-tbaa -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s -check-prefix=PATH<br>
> +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -no-struct-path-tbaa -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
> +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s -check-prefix=PATH<br>
> // Test TBAA metadata generated by front-end.<br>
><br>
> typedef unsigned char uint8_t;<br>
><br>
> Modified: cfe/trunk/test/CodeGen/tbaa.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa.cpp?rev=191695&r1=191694&r2=191695&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/tbaa.cpp?rev=191695&r1=191694&r2=191695&view=diff</a><br>
> ==============================================================================<br>
> --- cfe/trunk/test/CodeGen/tbaa.cpp (original)<br>
> +++ cfe/trunk/test/CodeGen/tbaa.cpp Mon Sep 30 14:35:19 2013<br>
> @@ -1,5 +1,5 @@<br>
> -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
> -// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -struct-path-tbaa -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s -check-prefix=PATH<br>
> +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -no-struct-path-tbaa -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s<br>
> +// RUN: %clang_cc1 -triple x86_64-apple-darwin -O1 -disable-llvm-optzns %s -emit-llvm -o - | FileCheck %s -check-prefix=PATH<br>
> // Test TBAA metadata generated by front-end.<br>
><br>
> typedef unsigned char uint8_t;<br>
><br>
><br>
> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>