<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Oct 1, 2013, at 9:52 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap: break-word; "><div class="h5"><blockquote type="cite"><div style="word-wrap: break-word; "><blockquote type="cite"><div style="word-wrap: break-word; "><div>On Oct 1, 2013, at 8:56 AM, jahanian <<a href="mailto:fjahanian@apple.com" target="_blank" class="cremed">fjahanian@apple.com</a>> wrote:</div><br><blockquote type="cite"><div style="word-wrap: break-word; ">We can disable build of libcxx on our VS buildbots. But, we would like to hear better alternatives/suggestions, if any.<div><br></div><div>- Thanks, Fariborz</div><div><br><div><br><div><div>On Sep 30, 2013, at 9:03 AM, jahanian <<a href="mailto:fjahanian@apple.com" target="_blank" class="cremed">fjahanian@apple.com</a>> wrote:</div><br><blockquote type="cite"><div style="word-wrap: break-word; ">HI Chandler,<div>This patch <br><div><div><pre style="color: rgb(51, 51, 51); font-size: 10px; ">Enable libcxx as part of the top level CMake build when it is checked
out in projects. This appears to be working on my system, and I will be
watching build bots to see if there are any issues on other platforms.</pre><div><br></div><div><h3 style="color: rgb(51, 51, 51); font-family: Verdana, sans-serif; ">Changed files</h3><ul style="color: rgb(51, 51, 51); font-size: 10px; font-family: Verdana, sans-serif; "><li style="padding: 0.1em 1em; background-color: rgb(246, 246, 246); "><b>src/projects/CMakeLists.txt</b></li></ul><div><br></div></div><div>causes all libcxx compiles to fail on VS buildbot. AN example of diagnostics would be:</div></div><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> hash.cpp</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; ">C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(927): error C2681: 'add_rvalue_reference<_Tp*>::type' : invalid expression type for dynamic_cast [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\lib\cxx.vcxproj]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; ">C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(927): error C2681: 'add_rvalue_reference<_Tp*>::type' : invalid expression type for dynamic_cast [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\lib\cxx.vcxproj]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; ">C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(927): error C2681: 'add_rvalue_reference<_Tp*>::type' : invalid expression type for dynamic_cast [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\l</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; ">ib\cxx.vcxproj]C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(1404): error C2516: 'std::common_type<_Tp>::type' : is not a legal base class [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\lib\cxx.vcxproj]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> with</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> [</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> _Tp=</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> ]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(1328) : see declaration of 'std::common_type<_Tp>::type'</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> with</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> [</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> _Tp=</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; "> ]</div></div><div><br></div><div>- Fariborz</div></div></div></div></blockquote></div></div></div></div></blockquote></div></blockquote></div></blockquote></div></div></blockquote></div></div></div></blockquote><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap: break-word; "><div class="h5"><blockquote type="cite"><div style="word-wrap: break-word; "><blockquote type="cite"><div style="word-wrap: break-word; "><blockquote type="cite"><div style="word-wrap: break-word; "><div><div><div><blockquote type="cite"><div style="word-wrap: break-word; "><div><div><div><br></div></div></div></div></blockquote></div></div></div></div></blockquote></div></blockquote></div></blockquote></div></div></blockquote></div></div></div></div><blockquote type="cite"><div dir="ltr">On Tue, Oct 1, 2013 at 11:45 AM, Bob Wilson <span dir="ltr"><<a href="mailto:bob.wilson@apple.com" target="_blank" class="cremed">bob.wilson@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">If libcxx doesn't build with Visual Studio, then Chandler's patch to enable it should be changed to make it conditional on not using VS. Chandler, can that be done?</div>
</blockquote><div><br></div><div>Yep, just been stuck in meetings. I'll get this after lunch if none beat me to it. Sorry for the delays. </div></div></div></div></blockquote><div><br></div><a href="http://blogs.msdn.com/b/vcblog/archive/2011/09/12/10209291.aspx">http://blogs.msdn.com/b/vcblog/archive/2011/09/12/10209291.aspx</a> says that VC does not support SFINAE on expressions.</div><div><br></div><div>The offending line is:</div><div><div>template<typename _Tp> char &__is_polymorphic_impl(</div><div> typename enable_if<sizeof((_Tp*)dynamic_cast<const volatile void*>(declval<_Tp*>())) != 0, int>::type);</div><div><br></div></div><div><br></div><div><br></div><div>-- Marshall</div><div><br></div><div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px; ">Marshall Clow Idio Software <<a href="mailto:mclow.lists@gmail.com">mailto:mclow.lists@gmail.com</a>><br><br>A.D. 1517: Martin Luther nails his 95 Theses to the church door and is promptly moderated down to (-1, Flamebait).<br> -- Yu Suzuki</span>
</div>
<br></body></html>