<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">HI Chandler,<div>This patch <br><div><div><pre class="comments" style="color: rgb(51, 51, 51); font-size: 10px; background-color: rgb(255, 255, 255); position: static; z-index: auto;">Enable libcxx as part of the top level CMake build when it is checked
out in projects. This appears to be working on my system, and I will be
watching build bots to see if there are any issues on other platforms.</pre><div><br></div><div><h3 class="files" style="color: rgb(51, 51, 51); font-family: Verdana, sans-serif; background-color: rgb(255, 255, 255);">Changed files</h3><ul style="color: rgb(51, 51, 51); font-family: Verdana, sans-serif; font-size: 10px; background-color: rgb(255, 255, 255);"><li class="alt" style="padding: 0.1em 1em; background-color: rgb(246, 246, 246);"><b>src/projects/CMakeLists.txt</b></li></ul><div><br></div></div><div>causes all libcxx compiles to fail on VS buildbot. AN example of diagnostics would be:</div></div><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> hash.cpp</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(927): error C2681: 'add_rvalue_reference<_Tp*>::type' : invalid expression type for dynamic_cast [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\lib\cxx.vcxproj]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(927): error C2681: 'add_rvalue_reference<_Tp*>::type' : invalid expression type for dynamic_cast [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\lib\cxx.vcxproj]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(927): error C2681: 'add_rvalue_reference<_Tp*>::type' : invalid expression type for dynamic_cast [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\l</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">ib\cxx.vcxproj]C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(1404): error C2516: 'std::common_type<_Tp>::type' : is not a legal base class [C:\public\zorg\buildbot\smooshlab\slave-0.8\...\clang-build\210328\projects\libcxx\lib\cxx.vcxproj]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> with</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> _Tp=</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> ]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> C:/public/zorg/buildbot/smooshlab/slave-0.8/.../src/projects/libcxx/include\type_traits(1328) : see declaration of 'std::common_type<_Tp>::type'</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> with</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> _Tp=</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> ]</div></div><div><br></div><div>- Fariborz</div><div><br></div><div><br></div></div></div></body></html>