<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Tim,<br>
<br>
Actually I already added a new test
<meta http-equiv="content-type" content="text/html;
charset=ISO-8859-1">
<a href="http://llvm-reviews.chandlerc.com/D1753#dd97ddbf">http://llvm-reviews.chandlerc.com/D1753#dd97ddbf</a>
to check fmla will not be generated when -fp-contract=fast is not in
command line, although I'm using CHECK rather than CHECK-NOT.<br>
<br>
; RUN: llc < %s -verify-machineinstrs
-mtriple=aarch64-none-linux-gnu -mattr=+neon | FileCheck %s<br>
<br>
define <2 x float> @test_vfma_lane_f32(<2 x float> %a,
<2 x float> %b, <2 x float> %v) {<br>
; CHECK: test_vfma_lane_f32:<br>
; CHECK: fmul {{v[0-9]+}}.2s, {{v[0-9]+}}.2s,
{{v[0-9]+}}.s[{{[0-9]+}}]<br>
; CHECK: fadd {{v[0-9]+}}.2s, {{v[0-9]+}}.2s, {{v[0-9]+}}.2s<br>
entry:<br>
%shuffle = shufflevector <2 x float> %v, <2 x float>
undef, <2 x i32> <i32 1, i32 1><br>
%mul = fmul <2 x float> %shuffle, %b<br>
%add = fadd <2 x float> %mul, %a<br>
ret <2 x float> %add<br>
}<br>
<br>
Thanks,<br>
-Jiangning<br>
<br>
On 09/30/2013 01:52 AM, Tim Northover wrote:
<blockquote
cite="mid:CAFHTzfJXUZyXua9JFMTJ7sBkojBTZzrLqkx48CSgfNTzCp_LgQ@mail.gmail.com"
type="cite">
<pre wrap="">Hi Jiangning,
Sorry I didn't get a chance to reply on Friday, and thanks for
reworking the patch.
</pre>
<blockquote type="cite">
<pre wrap=""> For register definition 'Re', I didn't make change.
</pre>
</blockquote>
<pre wrap="">
Fair enough.
I think it looks pretty much OK now, though I'd be happier if there
was a test that we *weren't* generating fmla instructions all the time
(perhaps with a comment about it being intentional). It's a very
tempting "optimisation" to make.
I think you should commit, with or without that though. I'll take a
look over the revision after-wards.
Cheers.
Tim.
</pre>
</blockquote>
<br>
</body>
</html>