<div dir="ltr">On 27 September 2013 06:39, Richard Smith <span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="im">On Thu, Sep 26, 2013 at 10:06 PM, Nick Lewycky <span dir="ltr"><<a href="mailto:nicholas@mxc.ca" target="_blank">nicholas@mxc.ca</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: nicholas<br>
Date: Fri Sep 27 00:06:31 2013<br>
New Revision: 191486<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=191486&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=191486&view=rev</a><br>
Log:<br>
Add -fno-unsigned-char and ignore it. We already support -fno-signed-char, add<br>
both flags to the driver test.<br></blockquote><div><br></div></div><div>Should we really be ignoring this?</div></div></div></div></blockquote><div><br></div><div>Of course not, but this documents it as needing an implementation.</div>
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> I would have thought we should look for the last of -fsigned-char, -fno-unsigned-char, -funsigned-char, -fno-signed-char, and pick a signed type unless the last flag (if any) is one of the latter two.</div>
<div><br></div><div>For instance, -funsigned-char -fno-unsigned-char should probably leave char signed.</div></div></div></div></blockquote><div><br></div><div>I didn't implement it because I don't know whether it undoes a -f(un)?signed-char leaving it to the default, or if -fno-signed-char --> -funsigned-char and -fno-unsigned-char --> -fsigned-char.</div>
<div><br></div><div>NIck</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Modified:<br>
cfe/trunk/include/clang/Driver/Options.td<br>
cfe/trunk/test/Driver/clang_f_opts.c<br>
<br>
Modified: cfe/trunk/include/clang/Driver/Options.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=191486&r1=191485&r2=191486&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Driver/Options.td?rev=191486&r1=191485&r2=191486&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Driver/Options.td (original)<br>
+++ cfe/trunk/include/clang/Driver/Options.td Fri Sep 27 00:06:31 2013<br>
@@ -796,6 +796,7 @@ def fno_unroll_loops : Flag<["-"], "fno-<br>
HelpText<"Turn off loop unroller">, Flags<[CC1Option]>;<br>
def funsigned_bitfields : Flag<["-"], "funsigned-bitfields">, Group<f_Group>;<br>
def funsigned_char : Flag<["-"], "funsigned-char">, Group<f_Group>;<br>
+def fno_unsigned_char : Flag<["-"], "fno-unsigned-char">, Group<clang_ignored_f_Group>;<br>
def funwind_tables : Flag<["-"], "funwind-tables">, Group<f_Group>;<br>
def fuse_cxa_atexit : Flag<["-"], "fuse-cxa-atexit">, Group<f_Group>;<br>
def fuse_init_array : Flag<["-"], "fuse-init-array">, Group<f_Group>, Flags<[CC1Option]>,<br>
<br>
Modified: cfe/trunk/test/Driver/clang_f_opts.c<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang_f_opts.c?rev=191486&r1=191485&r2=191486&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang_f_opts.c?rev=191486&r1=191485&r2=191486&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/test/Driver/clang_f_opts.c (original)<br>
+++ cfe/trunk/test/Driver/clang_f_opts.c Fri Sep 27 00:06:31 2013<br>
@@ -124,4 +124,6 @@<br>
// RUN: -fno-builtin-foobar \<br>
// RUN: -fno-builtin-strcat -fno-builtin-strcpy \<br>
// RUN: -fno-var-tracking \<br>
+// RUN: -fno-unsigned-char \<br>
+// RUN: -fno-signed-char \<br>
// RUN: %s<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div></div></div><br></div></div>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div>