LGTM<span></span><br><br>On Wednesday, September 18, 2013, Ben Langmuir  wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Make feature 'sha' depend on sse2, and disable sha when disabling sse2.<br>

<br>
Hi craig.topper, echristo,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1707" target="_blank">http://llvm-reviews.chandlerc.com/D1707</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
  <a href="http://llvm-reviews.chandlerc.com/D1707?vs=4365&id=4385#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1707?vs=4365&id=4385#toc</a><br>
<br>
Files:<br>
  include/clang/Basic/BuiltinsX86.def<br>
  include/clang/Driver/Options.td<br>
  lib/Basic/Targets.cpp<br>
  lib/Headers/CMakeLists.txt<br>
  lib/Headers/shaintrin.h<br>
  lib/Headers/x86intrin.h<br>
  test/CodeGen/builtins-x86.c<br>
  test/CodeGen/sha-builtins.c<br>
  test/Preprocessor/x86_target_features.c<br>
</blockquote><br><br>-- <br>~Craig<br>