<div dir="ltr">On Mon, Sep 16, 2013 at 10:12 PM, Ariel J. Bernal <span dir="ltr"><<a href="mailto:ariel.j.bernal@intel.com" target="_blank">ariel.j.bernal@intel.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ajbernal<br>
Date: Mon Sep 16 15:12:22 2013<br>
New Revision: 190803<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=190803&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=190803&view=rev</a><br>
Log:<br>
Fix for removing not included files from a compilation database.<br>
<br>
remove_if doesn't alter the container properties. Need to use erase to remove<br>
the elements past the new end.<br></blockquote><div><br></div><div>I'd suggest to add a regression test ...</div><div><br></div><div>Cheers,</div><div>/Manuel</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Modified:<br>
    clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp<br>
<br>
Modified: clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp?rev=190803&r1=190802&r2=190803&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp?rev=190803&r1=190802&r2=190803&view=diff</a><br>

==============================================================================<br>
--- clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp (original)<br>
+++ clang-tools-extra/trunk/clang-modernize/tool/ClangModernize.cpp Mon Sep 16 15:12:22 2013<br>
@@ -360,7 +360,9 @@ int main(int argc, const char **argv) {<br>
     // Use source paths from the compilation database.<br>
     // We only transform files that are explicitly included.<br>
     Sources = Compilations->getAllFiles();<br>
-    std::remove_if(Sources.begin(), Sources.end(), isFileNotIncludedPredicate);<br>
+    std::vector<std::string>::iterator E = std::remove_if(<br>
+        Sources.begin(), Sources.end(), isFileNotIncludedPredicate);<br>
+    Sources.erase(E, Sources.end());<br>
   }<br>
<br>
   if (Sources.empty()) {<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>