<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 16, 2013 at 5:51 PM, Eli Friedman <span dir="ltr"><<a href="mailto:eli.friedman@gmail.com" target="_blank">eli.friedman@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: efriedma<br>
Date: Mon Sep 16 19:51:31 2013<br>
New Revision: 190834<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=190834&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=190834&view=rev</a><br>
Log:<br>
Address review comment on r189557.<br>
<br>
We need to escape filenames the same way in InclusionRewriter whether<br>
UseLineDirective is true or false.<br></blockquote><div><br></div><div>Is this missing a test case?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Review comment from <a href="http://llvm.org/bugs/show_bug.cgi?id=17018#c2" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=17018#c2</a><br>
<br>
Modified:<br>
    cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp<br>
<br>
Modified: cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp?rev=190834&r1=190833&r2=190834&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp?rev=190834&r1=190833&r2=190834&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp (original)<br>
+++ cfe/trunk/lib/Rewrite/Frontend/InclusionRewriter.cpp Mon Sep 16 19:51:31 2013<br>
@@ -110,7 +110,9 @@ void InclusionRewriter::WriteLineInfo(co<br>
   if (!ShowLineMarkers)<br>
     return;<br>
   if (UseLineDirective) {<br>
-    OS << "#line" << ' ' << Line << ' ' << '"' << Filename << '"';<br>
+    OS << "#line" << ' ' << Line << ' ' << '"';<br>
+    OS.write_escaped(Filename);<br>
+    OS << '"';<br>
   } else {<br>
     // Use GNU linemarkers as described here:<br>
     // <a href="http://gcc.gnu.org/onlinedocs/cpp/Preprocessor-Output.html" target="_blank">http://gcc.gnu.org/onlinedocs/cpp/Preprocessor-Output.html</a><br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>