<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 13, 2013 at 10:12 AM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: chapuni<br>
Date: Fri Sep 13 12:12:09 2013<br>
New Revision: 190705<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=190705&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=190705&view=rev</a><br>
Log:<br>
ASTContext.cpp: Fix a warning in r190684. [-Wcovered-switch-default]<br>
<br>
Modified:<br>
    cfe/trunk/lib/AST/ASTContext.cpp<br>
<br>
Modified: cfe/trunk/lib/AST/ASTContext.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=190705&r1=190704&r2=190705&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTContext.cpp?rev=190705&r1=190704&r2=190705&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/AST/ASTContext.cpp (original)<br>
+++ cfe/trunk/lib/AST/ASTContext.cpp Fri Sep 13 12:12:09 2013<br>
@@ -698,7 +698,6 @@ static const LangAS::Map *getAddressSpac<br>
 static bool isAddrSpaceMapManglingEnabled(const TargetInfo &TI,<br>
                                           const LangOptions &LangOpts) {<br>
   switch (LangOpts.getAddressSpaceMapMangling()) {<br>
-  default: return false;<br>
   case LangOptions::ASMM_Target:<br>
     return TI.useAddressSpaceMapMangling();<br>
   case LangOptions::ASMM_On:<br>
@@ -706,6 +705,8 @@ static bool isAddrSpaceMapManglingEnable<br>
   case LangOptions::ASMM_Off:<br>
     return false;<br>
   }<br>
+  llvm_unreachable("getAddressSpaceMapMangling() doesn't cover anything.");<br>
+  return false;<br></blockquote><div><br></div><div>Could you drop the return after unreachable? We don't usually do that.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

 }<br>
<br>
 ASTContext::ASTContext(LangOptions& LOpts, SourceManager &SM,<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div></div>