<div dir="ltr">Thank you for review. Committed as <span style="font-size:11pt;font-family:"Calibri","sans-serif"">r190528.</span></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 11, 2013 at 4:21 AM, Manuel Klimek <span dir="ltr"><<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
  lg for the testing side, with the grammar updates :)<br>
<br>
<br>
================<br>
Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:158<br>
@@ -146,1 +157,3 @@<br>
<div class="im"><br>
+// Test RAV visits parameter variable declaration of implicit<br>
+// copy assignment operator.<br>
</div>----------------<br>
of *the* implicit?<br>
<br>
================<br>
Comment at: unittests/Tooling/RecursiveASTVisitorTest.cpp:165<br>
@@ +164,3 @@<br>
<div class="im">+  // same SourceLocation with its class declaration, so we match an empty name<br>
+  // with class source location here.<br>
</div><div class="im">+  Visitor.ExpectMatch("", 1, 7);<br>
</div>----------------<br>
I'd say "with the class' source location"<br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D958" target="_blank">http://llvm-reviews.chandlerc.com/D958</a><br>
</blockquote></div><br></div>