<div dir="ltr">Thanks for tracking this down! Fixed in r190124.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 6, 2013 at 1:04 AM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank">tobias@grosser.es</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 08/27/2013 04:09 AM, Daniel Jasper wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: djasper<br>
Date: Tue Aug 27 06:09:05 2013<br>
New Revision: 189337<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189337&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=189337&view=rev</a><br>
Log:<br>
clang-format: Revamp builder-type call formatting.<br>
<br>
Previously builder-type calls were only correctly recognized in<br>
top-level calls.<br>
<br>
This fixes <a href="http://llvm.org/PR16981" target="_blank">llvm.org/PR16981</a>.<br>
Before:<br>
   someobj->Add((new util::filetools::Handler(dir))<u></u>->OnEvent1(<br>
       NewPermanentCallback(this, &HandlerHolderClass::<u></u>EventHandlerCBA))<br>
                    ->OnEvent2(<u></u>NewPermanentCallback(<br>
                                   this, &HandlerHolderClass::<u></u>EventHandlerCBB))<br>
                    ->OnEvent3(<u></u>NewPermanentCallback(<br>
                                   this, &HandlerHolderClass::<u></u>EventHandlerCBC))<br>
                    ->OnEvent5(<u></u>NewPermanentCallback(<br>
                                   this, &HandlerHolderClass::<u></u>EventHandlerCBD))<br>
                    ->OnEvent6(<u></u>NewPermanentCallback(<br>
                          this, &HandlerHolderClass::<u></u>EventHandlerCBE)));<br>
<br>
After:<br>
   someobj->Add((new util::filetools::Handler(dir))<br>
                    ->OnEvent1(<u></u>NewPermanentCallback(<br>
                          this, &HandlerHolderClass::<u></u>EventHandlerCBA))<br>
                    ->OnEvent2(<u></u>NewPermanentCallback(<br>
                          this, &HandlerHolderClass::<u></u>EventHandlerCBB))<br>
                    ->OnEvent3(<u></u>NewPermanentCallback(<br>
                          this, &HandlerHolderClass::<u></u>EventHandlerCBC))<br>
                    ->OnEvent5(<u></u>NewPermanentCallback(<br>
                          this, &HandlerHolderClass::<u></u>EventHandlerCBD))<br>
                    ->OnEvent6(<u></u>NewPermanentCallback(<br>
                          this, &HandlerHolderClass::<u></u>EventHandlerCBE)));<br>
</blockquote>
<br></div></div>
Hi Daniel,<br>
<br>
this change introduced a regression:<br>
<br>
== Before the change ==<br>
<br>
bool foo() {<br>
  if (APF.convertToInteger(&<u></u>UIntVal, 64, true, APFloat::rmTowardZero,<br>
                           &isExact) != APFloat::opOK ||<br>
      !isExact)<br>
    return false<br>
}<br>
<br>
== After the change ==<br>
<br>
bool foo() {<br>
  if (APF.convertToInteger(&<u></u>UIntVal, 64, true, APFloat::rmTowardZero,<br>
                           &isExact) !=<br>
          APFloat::opOK ||<br>
      !isExact)<br>
    return false<br>
}<br>
<br>
The line break which is introduced by this change after the '!=' seems to be a formatting regression.<br>
<br>
Cheers,<br>
Tobias<br>
<br>
</blockquote></div><br></div>