<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>The diff on Phabricator generally only works if you include the full file as context (or generate it through the "arc" tool). This is probably a Phabricator bug, since the line numbers are clearly in the rich display but not through "Download Raw Diff". Can you upload the patch one more time with full context?</div><br><div><div>On Aug 30, 2013, at 10:21 , Karthik Bhat <<a href="mailto:blitz.opensource@gmail.com">blitz.opensource@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Thanks Jordan,Ted,Richard,<div>Could someone commit it for me as i don't have the permissions.</div><div>Thanks!</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 30, 2013 at 10:44 PM, Ted Kremenek <span dir="ltr"><<a href="mailto:kremenek@apple.com" target="_blank">kremenek@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks good to me.<br>
<div class="im"><br>
On Aug 30, 2013, at 9:46 AM, Jordan Rose <<a href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>> wrote:<br>
<br>
><br>
> P.S. Please remember to add cfe-commits as a CC for patches.<br>
><br>
> <a href="http://llvm-reviews.chandlerc.com/D1529" target="_blank">http://llvm-reviews.chandlerc.com/D1529</a><br>
</div>> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></body></html>