<div dir="ltr">Won't this change trigger clang -Wcovered-switch-default?  Isn't the preferred way to put llvm_unreachable() after the switch?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 29, 2013 at 1:25 PM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: aaronballman<br>
Date: Thu Aug 29 15:25:14 2013<br>
New Revision: 189605<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189605&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=189605&view=rev</a><br>
Log:<br>
Silencing a rather spurious warning from MSVC 11 about not all control paths returning a value (hint: they do).<br>
<br>
Modified:<br>
    cfe/trunk/lib/Analysis/Consumed.cpp<br>
<br>
Modified: cfe/trunk/lib/Analysis/Consumed.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/Consumed.cpp?rev=189605&r1=189604&r2=189605&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Analysis/Consumed.cpp?rev=189605&r1=189604&r2=189605&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Analysis/Consumed.cpp (original)<br>
+++ cfe/trunk/lib/Analysis/Consumed.cpp Thu Aug 29 15:25:14 2013<br>
@@ -74,6 +74,7 @@ static bool isKnownState(ConsumedState S<br>
     return true;<br>
   case CS_None:<br>
   case CS_Unknown:<br>
+  default:<br>
     return false;<br>
   }<br>
 }<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>