<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>Starting this patch:</div><div><br></div><div><pre class="comments" style="color: rgb(51, 51, 51); font-size: 10px; background-color: rgb(255, 255, 255);">Summary:
Add support for eachOf/allOf/anyOf variadic matchers in the dynamic layer.
These function require some late binding behavior for the type conversions, thus changes in VariadicValue's MatcherList.
Second try. This time with a fix for C++11 builds.</pre><div><br></div></div><div><br></div><div><h3 class="files" style="color: rgb(51, 51, 51); font-family: Verdana, sans-serif; background-color: rgb(255, 255, 255);">Changed files</h3><ul style="color: rgb(51, 51, 51); font-family: Verdana, sans-serif; font-size: 10px; background-color: rgb(255, 255, 255);"><li class="alt" style="padding: 0.1em 1em; background-color: rgb(246, 246, 246);"><b>src/tools/clang/include/clang/ASTMatchers/Dynamic/VariantValue.h</b></li><li class="" style="padding: 0.1em 1em;"><b>src/tools/clang/lib/ASTMatchers/Dynamic/Marshallers.h</b></li><li class="alt" style="padding: 0.1em 1em; background-color: rgb(246, 246, 246);"><b>src/tools/clang/lib/ASTMatchers/Dynamic/Registry.cpp</b></li><li class="" style="padding: 0.1em 1em;"><b>src/tools/clang/lib/ASTMatchers/Dynamic/VariantValue.cpp</b></li><li class="alt" style="padding: 0.1em 1em; background-color: rgb(246, 246, 246);"><b>src/tools/clang/unittests/ASTMatchers/Dynamic/ParserTest.cpp</b></li><li class="" style="padding: 0.1em 1em;"><b>src/tools/clang/unittests/ASTMatchers/Dynamic/RegistryTest.cpp</b></li></ul><div><br></div></div><div>This test fails on a VS windows buildbot. Please investigate.</div><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">Failing Tests (1):</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Clang-Unit :: ASTMatchers/Dynamic/Release/DynamicASTMatchersTests.exe/RegistryTest.VariadicOp</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">FAIL: Clang-Unit :: ASTMatchers/Dynamic/Release/DynamicASTMatchersTests.exe/RegistryTest.VariadicOp (5871 of 6552)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> ******************** TEST 'Clang-Unit :: ASTMatchers/Dynamic/Release/DynamicASTMatchersTests.exe/RegistryTest.VariadicOp' FAILED ********************</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Note: Google Test filter = RegistryTest.VariadicOp</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [==========] Running 1 test from 1 test case.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [----------] Global test environment set-up.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [----------] 1 test from RegistryTest</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [ RUN ] RegistryTest.VariadicOp</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">..\..\..\..\..\..\..\src\tools\clang\unittests\ASTMatchers\Dynamic\RegistryTest.cpp(273): error : Value of: matches("int i = 0;", D) [C:\...\clang-build\200412\tools\clang\test\check-clang.vcxproj]</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Actual: true</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Expected: false</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [ FAILED ] RegistryTest.VariadicOp (15 ms)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [----------] 1 test from RegistryTest (15 ms total)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [----------] Global test environment tear-down</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [==========] 1 test from 1 test case ran. (15 ms total)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [ PASSED ] 0 tests.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [ FAILED ] 1 test, listed below:</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> [ FAILED ] RegistryTest.VariadicOp</div></div><div><br></div><div><br></div><div>Thanks, Fariborz</div><div><br></div><div><br></div></div></body></html>