<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Looks good to me. Do you need someone to commit for you?</div><div><br></div><div>Jordan</div><div><br></div><br><div><div>On Aug 26, 2013, at 12:29 , Edoardo P. <<a href="mailto:ed0.88.prez@gmail.com">ed0.88.prez@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Ok, updated the patch with FILEPATH.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/8/26 Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Most of our path variables point to directories or can be relative paths, so they have type PATH. I'm not sure CLANG_ORDER_FILE can be relative, and it has to point to a file that already exists, so using FILEPATH makes sense.</div>
<div><div class="h5"><br><div><div>On Aug 23, 2013, at 17:46 , "Edoardo P." <<a href="mailto:ed0.88.prez@gmail.com" target="_blank">ed0.88.prez@gmail.com</a>> wrote:</div><br><blockquote type="cite"><div dir="ltr">
I was not sure about it, because with a quick search through the cmake files I couldn't find another variable with said type. Should I still change it?<br></div><div class="gmail_extra"><br><br>
<div class="gmail_quote">2013/8/24 Jordan Rose <span dir="ltr"><<a href="mailto:jordan_rose@apple.com" target="_blank">jordan_rose@apple.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Actually, it should be a FILEPATH, shouldn't it?<br>
<div><br>
On Aug 23, 2013, at 16:00 , Edoardo P. <<a href="mailto:ed0.88.prez@gmail.com" target="_blank">ed0.88.prez@gmail.com</a>> wrote:<br>
<br>
> Hi,<br>
><br>
> I noticed that in tools/clang/CMakeLists.txt CLANG_ORDER_FILE was added, but it was defined with the cmake function 'option', which makes the variable a BOOL, which is wrong. I noticed it when I got: 'error: cannot open ON: No such file or directory' when linking clang executable. This happened because I accidentally checked the 'option' CLANG_ORDER_FILE with cmake-gui. Since it is a filename, it should be defined as a STRING with 'set'. The attached patch should fix this.<br>
><br>
> Regards,<br>
> Edward-san<br>
> --<br>
> Mathematics is the language with which God has written the universe. (Galilei)<br>
</div><br>> _______________________________________________<br>
> cfe-commits mailing list<br>
> <a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
<br></blockquote></div><br><br clear="all"><br>-- <br>Mathematics is the language with which God has written the universe. (Galilei)
</div>
</blockquote></div><br></div></div></div>
</blockquote></div><br><br clear="all"><br>-- <br>Mathematics is the language with which God has written the universe. (Galilei)
</div>
</blockquote></div></body></html>