<div dir="ltr">Please document this is the release notes. If possible, also adding a test case? But I suspect you can't test this yet.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 23, 2013 at 2:34 PM, Shuxin Yang <span dir="ltr"><<a href="mailto:shuxin.llvm@gmail.com" target="_blank">shuxin.llvm@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: shuxin_yang<br>
Date: Fri Aug 23 16:34:57 2013<br>
New Revision: 189148<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189148&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=189148&view=rev</a><br>
Log:<br>
Driver::IsUsingLTO() no longer return true when seeing -emit-llvm.<br>
<br>
One step toward differentiating following two commands:<br>
   clang -O3 -flto a.c -c, and<br>
   clang -O3 -emit-llvm a.c<br>
<br>
Thanks many awesome folks for clarifying things.<br>
<br>
Modified:<br>
    cfe/trunk/lib/Driver/Driver.cpp<br>
<br>
Modified: cfe/trunk/lib/Driver/Driver.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=189148&r1=189147&r2=189148&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Driver.cpp?rev=189148&r1=189147&r2=189148&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/Driver/Driver.cpp (original)<br>
+++ cfe/trunk/lib/Driver/Driver.cpp Fri Aug 23 16:34:57 2013<br>
@@ -1340,6 +1340,10 @@ Action *Driver::ConstructPhaseAction(con<br>
       types::ID Output =<br>
         Args.hasArg(options::OPT_S) ? types::TY_LTO_IR : types::TY_LTO_BC;<br>
       return new CompileJobAction(Input, Output);<br>
+    } else if (Args.hasArg(options::OPT_emit_llvm)) {<br>
+      types::ID Output =<br>
+        Args.hasArg(options::OPT_S) ? types::TY_LLVM_IR : types::TY_LLVM_BC;<br>
+      return new CompileJobAction(Input, Output);<br>
     } else {<br>
       return new CompileJobAction(Input, types::TY_PP_Asm);<br>
     }<br>
@@ -1352,9 +1356,7 @@ Action *Driver::ConstructPhaseAction(con<br>
 }<br>
<br>
 bool Driver::IsUsingLTO(const ArgList &Args) const {<br>
-  // Check for -emit-llvm or -flto.<br>
-  if (Args.hasArg(options::OPT_emit_llvm) ||<br>
-      Args.hasFlag(options::OPT_flto, options::OPT_fno_lto, false))<br>
+  if (Args.hasFlag(options::OPT_flto, options::OPT_fno_lto, false))<br>
     return true;<br>
<br>
   // Check for -O4.<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>