<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I believe this broke the public llvm builder:<div><br></div><div><a href="http://lab.llvm.org:8013/builders/phase1%20-%20sanity/builds/10418">http://lab.llvm.org:8013/builders/phase1%20-%20sanity/builds/10418</a></div><div><br></div><div>Can you fix/revert.</div><div><br></div><div>Michael</div><div><br><div><div>On Aug 19, 2013, at 3:20 PM, Juergen Ributzka <<a href="mailto:juergen@apple.com">juergen@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Author: ributzka<br>Date: Mon Aug 19 17:20:37 2013<br>New Revision: 188722<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=188722&view=rev">http://llvm.org/viewvc/llvm-project?rev=188722&view=rev</a><br>Log:<br>Simplify code by using CreateMemTemp. No functional change intended.<br><br>Reviewer: Eli<br><br>Modified:<br> cfe/trunk/lib/CodeGen/CGBuiltin.cpp<br><br>Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=188722&r1=188721&r2=188722&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/CodeGen/CGBuiltin.cpp?rev=188722&r1=188721&r2=188722&view=diff</a><br>==============================================================================<br>--- cfe/trunk/lib/CodeGen/CGBuiltin.cpp (original)<br>+++ cfe/trunk/lib/CodeGen/CGBuiltin.cpp Mon Aug 19 17:20:37 2013<br>@@ -2019,9 +2019,7 @@ Value *CodeGenFunction::EmitARMBuiltinEx<br> Function *F = CGM.getIntrinsic(Intrinsic::arm_strexd);<br> llvm::Type *STy = llvm::StructType::get(Int32Ty, Int32Ty, NULL);<br><br>- Value *One = llvm::ConstantInt::get(Int32Ty, 1);<br>- Value *Tmp = Builder.CreateAlloca(ConvertType(E->getArg(0)->getType()),<br>- One);<br>+ Value *Tmp = CreateMemTemp(E->getArg(0)->getType());<br> Value *Val = EmitScalarExpr(E->getArg(0));<br> Builder.CreateStore(Val, Tmp);<br><br>@@ -2928,19 +2926,15 @@ Value *CodeGenFunction::EmitX86BuiltinEx<br> return Builder.CreateExtractElement(Ops[0],<br> llvm::ConstantInt::get(Ops[1]->getType(), 0));<br> case X86::BI__builtin_ia32_ldmxcsr: {<br>- llvm::Type *PtrTy = Int8PtrTy;<br>- Value *One = llvm::ConstantInt::get(Int32Ty, 1);<br>- Value *Tmp = Builder.CreateAlloca(Int32Ty, One);<br>+ Value *Tmp = CreateMemTemp(E->getArg(0)->getType());<br> Builder.CreateStore(Ops[0], Tmp);<br> return Builder.CreateCall(CGM.getIntrinsic(Intrinsic::x86_sse_ldmxcsr),<br>- Builder.CreateBitCast(Tmp, PtrTy));<br>+ Builder.CreateBitCast(Tmp, Int8PtrTy));<br> }<br> case X86::BI__builtin_ia32_stmxcsr: {<br>- llvm::Type *PtrTy = Int8PtrTy;<br>- Value *One = llvm::ConstantInt::get(Int32Ty, 1);<br>- Value *Tmp = Builder.CreateAlloca(Int32Ty, One);<br>+ Value *Tmp = CreateMemTemp(E->getArg(0)->getType());<br> Builder.CreateCall(CGM.getIntrinsic(Intrinsic::x86_sse_stmxcsr),<br>- Builder.CreateBitCast(Tmp, PtrTy));<br>+ Builder.CreateBitCast(Tmp, Int8PtrTy));<br> return Builder.CreateLoad(Tmp, "stmxcsr");<br> }<br> case X86::BI__builtin_ia32_storehps:<br>@@ -3131,13 +3125,10 @@ Value *CodeGenFunction::EmitX86BuiltinEx<br> }<br> // AVX2 broadcast<br> case X86::BI__builtin_ia32_vbroadcastsi256: {<br>- llvm::Type *VecTy = llvm::VectorType::get(Int64Ty, 2);<br>- llvm::Type *PtrTy = Int8PtrTy;<br>- Value *One = llvm::ConstantInt::get(Int32Ty, 1);<br>- Value *Tmp = Builder.CreateAlloca(VecTy, One);<br>- Builder.CreateStore(Ops[0], Tmp);<br>- return Builder.CreateCall(CGM.getIntrinsic(Intrinsic::x86_avx2_vbroadcasti128),<br>- Builder.CreateBitCast(Tmp, PtrTy));<br>+ Value *VecTmp = CreateMemTemp(E->getArg(0)->getType());<br>+ Builder.CreateStore(Ops[0], VecTmp);<br>+ Value *F = CGM.getIntrinsic(Intrinsic::x86_avx2_vbroadcasti128);<br>+ return Builder.CreateCall(F, Builder.CreateBitCast(VecTmp, Int8PtrTy));<br> }<br> }<br>}<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></div></body></html>