<div dir="ltr">Hi Jordan,<div><br></div><div>This commit doesn't really make a lot of sense. lit already sanitizes the environment that it passes to subprocesses, it only propagates a small explicit list of environment variables (that happens to include LIBRARY_PATH).</div>
<div><br></div><div>I think we should just drop LIBRARY_PATH from the list of variables we propagate by default into the environment, any objections?</div><div><br></div><div> - Daniel</div></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Fri, Apr 6, 2012 at 7:59 PM, Jordan Rose <span dir="ltr"><<a href="mailto:jediknil@belkadan.com" target="_blank">jediknil@belkadan.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for the fix. This problem originally came up because I have a custom LIBRARY_PATH setting. If a Windows user has a custom INCLUDE setting, could it affect any of the Driver tests?<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Apr 6, 2012, at 21:05, NAKAMURA Takumi wrote:<br>
<br>
> Jordy,<br>
><br>
> Don't delete INCLUDE unconditionally. Fixed in r154240.<br>
> See also llvm r152588 and clang r152589.<br>
><br>
> ...Takumi<br>
><br>
><br>
> 2012/4/7 Jordy Rose <<a href="mailto:jediknil@belkadan.com">jediknil@belkadan.com</a>>:<br>
>> Author: jrose<br>
>> Date: Fri Apr  6 13:14:01 2012<br>
>> New Revision: 154188<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=154188&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=154188&view=rev</a><br>
>> Log:<br>
>> Clear environment variables that might affect Clang before running tests.<br>
>><br>
>> Modified:<br>
>>    cfe/trunk/test/lit.cfg<br>
>><br>
>> Modified: cfe/trunk/test/lit.cfg<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=154188&r1=154187&r2=154188&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/lit.cfg?rev=154188&r1=154187&r2=154188&view=diff</a><br>

>> ==============================================================================<br>
>> --- cfe/trunk/test/lit.cfg (original)<br>
>> +++ cfe/trunk/test/lit.cfg Fri Apr  6 13:14:01 2012<br>
>> @@ -46,6 +46,32 @@<br>
>>  config.llvm_src_root = getattr(config, 'llvm_src_root', None)<br>
>>  config.llvm_obj_root = getattr(config, 'llvm_obj_root', None)<br>
>><br>
>> +# Clear some environment variables that might affect Clang.<br>
>> +#<br>
>> +# This first set of vars are read by Clang, but shouldn't affect tests<br>
>> +# that aren't specifically looking for these features, or are required<br>
>> +# simply to run the tests at all.<br>
>> +#<br>
>> +# FIXME: Should we have a tool that enforces this?<br>
>> +<br>
>> +# safe_env_vars = ('TMPDIR', 'TEMP', 'TMP', 'USERPROFILE', 'PWD',<br>
>> +#                  'MACOSX_DEPLOYMENT_TARGET', 'IPHONEOS_DEPLOYMENT_TARGET',<br>
>> +#                  'IOS_SIMULATOR_DEPLOYMENT_TARGET',<br>
>> +#                  'VCINSTALLDIR', 'VC100COMNTOOLS', 'VC90COMNTOOLS',<br>
>> +#                  'VC80COMNTOOLS')<br>
>> +possibly_dangerous_env_vars = ('COMPILER_PATH', 'RC_DEBUG_OPTIONS', 'INCLUDE',<br>
>> +                               'CINDEXTEST_PREAMBLE_FILE', 'LIBRARY_PATH',<br>
>> +                               'CPATH', 'C_INCLUDE_PATH', 'CPLUS_INCLUDE_PATH',<br>
>> +                               'OBJC_INCLUDE_PATH', 'OBJCPLUS_INCLUDE_PATH',<br>
>> +                               'LIBCLANG_TIMING', 'LIBCLANG_OBJTRACKING',<br>
>> +                               'LIBCLANG_LOGGING', 'LIBCLANG_BGPRIO_INDEX',<br>
>> +                               'LIBCLANG_BGPRIO_EDIT', 'LIBCLANG_NOTHREADS',<br>
>> +                               'LIBCLANG_RESOURCE_USAGE',<br>
>> +                               'LIBCLANG_CODE_COMPLETION_LOGGING')<br>
>> +for name in possibly_dangerous_env_vars:<br>
>> +  if name in config.environment:<br>
>> +    del config.environment[name]<br>
>> +<br>
>>  # Tweak the PATH to include the tools dir and the scripts dir.<br>
>>  if clang_obj_root is not None:<br>
>>     llvm_tools_dir = getattr(config, 'llvm_tools_dir', None)<br>
>><br>
>><br>
>> _______________________________________________<br>
>> cfe-commits mailing list<br>
>> <a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</div></div></blockquote></div><br></div>