<html><body>
<p><font size="2" face="sans-serif">Hi Howard,</font><br>
<br>
<font size="2" face="sans-serif">Sure. I've revised as follows.</font><br>
<br>
<font size="2" face="sans-serif">Diffs:</font><br>
<i>(See attached file: buildit.diffs)</i><br>
<br>
<font size="2" face="sans-serif">The actual file:</font><br>
<i>(See attached file: buildit)</i><br>
<br>
<font size="2" face="sans-serif">However, the code in question does not seem to work to me. Notice libc++.so.1.0 is generated because of "-o libc++.so.1.0" in line 103. The 'ln -s libc++.so.1 libc++.so' command in line 141 will fail. That's why line 141 was changed to 'ln -s libc++.so.1.0" in the previous patch. I think the proper fix will be to change line 103 to "-o libc++.so.1" to be consistent with the soname.</font><br>
<br>
<font size="2" face="sans-serif">...</font><br>
<font size="2" face="sans-serif">100 *)</font><br>
<font size="2" face="sans-serif">101 RC_CFLAGS="-fPIC"</font><br>
<font size="2" face="sans-serif">102 SOEXT=so</font><br>
<font size="2" face="sans-serif">103 LDSHARED_FLAGS="-o libc++.so.1.0 \</font><br>
<font size="2" face="sans-serif">104 -shared -nodefaultlibs -Wl,-soname,libc++.so.1 \</font><br>
<font size="2" face="sans-serif">105 -lpthread -lrt -lc -lstdc++"</font><br>
<font size="2" face="sans-serif">106 ;;</font><br>
<font size="2" face="sans-serif">....</font><br>
<font size="2" face="sans-serif">139 *)</font><br>
<font size="2" face="sans-serif">140 rm -f libc++.so</font><br>
<font size="2" face="sans-serif">141 ln -s libc++.so.1 libc++.so</font><br>
<font size="2" face="sans-serif">142 ;;</font><br>
<font size="2" face="sans-serif"><br>
Thanks,<br>
Xing Xue<br>
XLC++ Compiler Development / IBM Software Solutions Toronto Lab.<br>
Tie Line: 313-3972 Phone: 905-413-3972 Email: xingxue@ca.ibm.com<br>
<br>
</font><br>
<br>
<img width="16" height="16" src="cid:3__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt="Inactive hide details for Howard Hinnant ---08/14/2013 10:00:34 AM---On Aug 14, 2013, at 3:45 AM, David Chisnall <theraven@Free"><font size="2" color="#424282" face="sans-serif">Howard Hinnant ---08/14/2013 10:00:34 AM---On Aug 14, 2013, at 3:45 AM, David Chisnall <theraven@FreeBSD.org> wrote: >> rm -f libc++.so</font><br>
<br>
<table width="100%" border="0" cellspacing="0" cellpadding="0">
<tr valign="top"><td width="1%"><img width="96" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<ul style="padding-left: 4pt"><font size="1" color="#5F5F5F" face="sans-serif">From:</font></ul>
</td><td width="100%"><img width="1" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<font size="1" face="sans-serif">Howard Hinnant <hhinnant@apple.com></font></td></tr>
<tr valign="top"><td width="1%"><img width="96" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<ul style="padding-left: 4pt"><font size="1" color="#5F5F5F" face="sans-serif">To:</font></ul>
</td><td width="100%"><img width="1" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<font size="1" face="sans-serif">Xing Xue/Toronto/IBM@IBMCA</font></td></tr>
<tr valign="top"><td width="1%"><img width="96" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<ul style="padding-left: 4pt"><font size="1" color="#5F5F5F" face="sans-serif">Cc:</font></ul>
</td><td width="100%" valign="middle"><img width="1" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<font size="1" face="sans-serif">"cfe-commits@cs.uiuc.edu cfe" <cfe-commits@cs.uiuc.edu>, David Chisnall <theraven@FreeBSD.org>, Michael Wong/Toronto/IBM@IBMCA, "compnerd@compnerd.org Abdulrasool" <compnerd@compnerd.org>, Dimitry Andric <dimitry@andric.com>, "Andrew C. Morrow" <andrew.c.morrow@gmail.com>, aep@exys.org, joerg@NetBSD.org, "jyasskin@google.com Yasskin" <jyasskin@google.com></font></td></tr>
<tr valign="top"><td width="1%"><img width="96" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<ul style="padding-left: 4pt"><font size="1" color="#5F5F5F" face="sans-serif">Date:</font></ul>
</td><td width="100%"><img width="1" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<font size="1" face="sans-serif">08/14/2013 10:00 AM</font></td></tr>
<tr valign="top"><td width="1%"><img width="96" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<ul style="padding-left: 4pt"><font size="1" color="#5F5F5F" face="sans-serif">Subject:</font></ul>
</td><td width="100%"><img width="1" height="1" src="cid:4__=0ABBF154DFCA31468f9e8a93df938@ca.ibm.com" border="0" alt=""><br>
<font size="1" face="sans-serif">Re: [libc++] Patch for AIX port</font></td></tr>
</table>
<hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br>
<br>
<br>
<tt><font size="2"><br>
On Aug 14, 2013, at 3:45 AM, David Chisnall <theraven@FreeBSD.org> wrote:<br>
<br>
>> rm -f libc++.so<br>
>> - ln -s libc++.so.1 libc++.so<br>
>> + ln -s libc++.so.1.0 libc++.so<br>
>> ;;<br>
>> esac<br>
>> <br>
>> All, please examine the last line:<br>
>> <br>
>> - ln -s libc++.so.1 libc++.so<br>
>> + ln -s libc++.so.1.0 libc++.so<br>
> <br>
> This does, however. We don't usually use a.b version numbers. It isn't of vital importance, however, as we don't use the upstream build system for the libc++ that we ship, although it would be mildly inconvenient for people who are building a newer version for testing.<br>
> <br>
> Oh, and ln -sf is generally better than rm then ln, as it allows the operation to be atomic.<br>
<br>
Xing, can you rework this part so that it is -ibm-only?<br>
<br>
Howard<br>
<br>
</font></tt><br>
<br>
</body></html>