<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">That would be great.<div><br></div><div>Thanks!<br><div><br><div><div>On 7 Aug 2013, at 16:08, Manuel Klimek <<a href="mailto:klimek@google.com">klimek@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Do you need me to commit it?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 7, 2013 at 12:20 AM, Thomas Gibson-Robinson <span dir="ltr"><<a href="mailto:thomas.gibsonrobinson@gmail.com" target="_blank">thomas.gibsonrobinson@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Sorry about that: next time I'll make sure to use phabricator.<div><br></div><div>
Thanks for looking at the patch!<div><div class="h5"><br><div><div>On 6 Aug 2013, at 18:50, Manuel Klimek <<a href="mailto:klimek@google.com" target="_blank">klimek@google.com</a>> wrote:</div><br><blockquote type="cite">
<div dir="ltr">LG. In the future, it would be cool if you could use phabricator (<a href="http://llvm-reviews.chandlerc.com/" target="_blank">http://llvm-reviews.chandlerc.com/</a>, docs at <a href="http://llvm.org/docs/Phabricator.html" target="_blank">http://llvm.org/docs/Phabricator.html</a>), as that makes it easier to review code in context. <div>
<br></div><div>Thanks!</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 5, 2013 at 2:32 PM, Thomas Gibson-Robinson <span dir="ltr"><<a href="mailto:thomas.gibsonrobinson@gmail.com" target="_blank">thomas.gibsonrobinson@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The attached patch fixes a couple of bugs with the Allman brace breaking. In particular, left braces after an enum declaration now occur on their own line. Further, when short ifs/whiles are allowed these no longer cause the left brace to be on the same line as the if/while when a brace is included. Tests are included.<br>
<br>
<br><br>
<br>
<br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div><br></div></div></div></div></blockquote></div><br></div>
</blockquote></div><br></div></div></body></html>