<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Can you restore attribute name in the diagnostic? They are usually wrapped in some MACRO name.<div>missing the attribute name in the diagnostic is a setback to clarity.<br><div><br></div><div>- Fariborz</div><div><br><div><div>On Jul 23, 2013, at 8:21 AM, Aaron Ballman <<a href="mailto:aaron@aaronballman.com">aaron@aaronballman.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Author: aaronballman<br>Date: Tue Jul 23 10:21:34 2013<br>New Revision: 186947<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=186947&view=rev">http://llvm.org/viewvc/llvm-project?rev=186947&view=rev</a><br>Log:<br>Fixing the build bots from the previous commit.<br><br>Modified:<br> cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m<br> cfe/trunk/test/SemaObjC/attr-root-class.m<br> cfe/trunk/test/SemaObjC/default-synthesize-3.m<br><br>Modified: cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m?rev=186947&r1=186946&r2=186947&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m?rev=186947&r1=186946&r2=186947&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m (original)<br>+++ cfe/trunk/test/SemaObjC/arc-unavailable-for-weakref.m Tue Jul 23 10:21:34 2013<br>@@ -87,6 +87,6 @@ __attribute__((objc_arc_weak_reference_u<br>@synthesize font = _font;<br>@end<br><br>-__attribute__((objc_arc_weak_reference_unavailable(1)))<span class="Apple-tab-span" style="white-space: pre;"> </span>// expected-error {{attribute 'objc_arc_weak_reference_unavailable' takes no arguments}}<br>+__attribute__((objc_arc_weak_reference_unavailable(1)))<span class="Apple-tab-span" style="white-space: pre;"> </span>// expected-error {{attribute takes no arguments}}<br>@interface I3<br>@end<br><br>Modified: cfe/trunk/test/SemaObjC/attr-root-class.m<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/attr-root-class.m?rev=186947&r1=186946&r2=186947&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/attr-root-class.m?rev=186947&r1=186946&r2=186947&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/SemaObjC/attr-root-class.m (original)<br>+++ cfe/trunk/test/SemaObjC/attr-root-class.m Tue Jul 23 10:21:34 2013<br>@@ -15,6 +15,6 @@ __attribute__((objc_root_class)) static<br>{<br>}<br><br>-__attribute__((objc_root_class(1))) // expected-error {{attribute 'objc_root_class' takes no arguments}}<br>+__attribute__((objc_root_class(1))) // expected-error {{attribute takes no arguments}}<br>@interface I1<br>@end<br><br>Modified: cfe/trunk/test/SemaObjC/default-synthesize-3.m<br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/default-synthesize-3.m?rev=186947&r1=186946&r2=186947&view=diff">http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/default-synthesize-3.m?rev=186947&r1=186946&r2=186947&view=diff</a><br>==============================================================================<br>--- cfe/trunk/test/SemaObjC/default-synthesize-3.m (original)<br>+++ cfe/trunk/test/SemaObjC/default-synthesize-3.m Tue Jul 23 10:21:34 2013<br>@@ -154,6 +154,6 @@ __attribute ((objc_requires_property_def<br>@synthesize failureCount = _failureCount;<br>@end<br><br>-__attribute ((objc_requires_property_definitions(1))) // expected-error {{attribute 'objc_requires_property_definitions' takes no arguments}}<br>+__attribute ((objc_requires_property_definitions(1))) // expected-error {{attribute takes no arguments}}<br>@interface I1<br>@end<br><br><br>_______________________________________________<br>cfe-commits mailing list<br><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></div></blockquote></div><br></div></div></body></html>