<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Committed in r186967, thanks!</div><br><div><div>On Jul 22, 2013, at 5:13 PM, Che-Liang Chiou <<a href="mailto:clchiou@gmail.com">clchiou@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Restored enum order.<br><br>On Mon, Jul 22, 2013 at 4:07 PM, Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com">akyrtzi@gmail.com</a>> wrote:<br><blockquote type="cite">On Jul 17, 2013, at 11:08 AM, Che-Liang Chiou <<a href="mailto:clchiou@gmail.com">clchiou@gmail.com</a>> wrote:<br><br>Tests updated.<br><br><br>Looks good, one final thing:<br><br>- CXType_Vector = 113<br>+ CXType_IncompleteArray = 113,<br>+ CXType_VariableArray = 114,<br>+ CXType_DependentSizedArray = 115,<br>+ CXType_Vector = 116<br><br>Don't change the enumerator for CXType_Vector, this must remain as is for<br>backwards compatibility.<br><br><br>On Tue, Jul 16, 2013 at 1:50 PM, Argyrios Kyrtzidis <<a href="mailto:akyrtzi@gmail.com">akyrtzi@gmail.com</a>><br>wrote:<br><br>Could you please also add some tests for the new CXTypes in<br>test/Index/print-type.cpp ?<br><br>On Jul 15, 2013, at 5:03 PM, Che-Liang Chiou <<a href="mailto:clchiou@gmail.com">clchiou@gmail.com</a>> wrote:<br><br>clang defines four types of array but only one of them (ConstantArray)<br>has been exposed through libclang interface. So add the rest of them.<br><libclang_array.patch><br><br><br><libclang_array.patch><br><br><br></blockquote><span><libclang_array.patch></span></div></blockquote></div><br></body></html>