<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jul 19, 2013, at 10:17 AM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:</div><blockquote type="cite"><div dir="ltr">On Fri, Jul 19, 2013 at 1:04 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Jul 12, 2013, at 5:39 AM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br>
> Canonical types are unchanged. The type printer had to be changed to<br>
> avoid printing any non-default implicit calling convention as well as<br>
> the calling convention attribute.<br>
<br>
</div>+bool AttributedType::isCallingConv() const {<br>
+ switch (getAttrKind()) {<br>
+ default: return false;<br>
+ case attr_cdecl:<br>
+ case attr_fastcall:<br>
+ case attr_stdcall:<br>
+ case attr_thiscall:<br>
+ case attr_pascal:<br>
+ case attr_pnaclcall:<br>
+ case attr_inteloclbicc:<br>
<br>
This seems to be missing the pcs attributes. If that's intentional, there should be a comment.<br></blockquote><div><br></div><div>Oops. I'll make this a fully covered switch.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- if (handleFunctionTypeAttr(state, attr, declSpecType)) {<br>
- spliceAttrOutOfList(attr, attrList);<br>
- return true;<br>
- }<br>
-<br>
- return false;<br>
+ return handleFunctionTypeAttr(state, attr, declSpecType);<br>
<br>
This is an unexplained change. Doesn't this cause the attribute<br>
to be potentially applied twice?<br></blockquote><div><br></div><div>I had to apply this change in order to get one of the TypeLocBuilders to succeed without asserting in fillAttributedType(). What might happen if the parsed attribute stays on the declspec?</div></div></div></div></blockquote><div><br></div></div>Oh, I see. You're right, there's no reason to splice this out.<br><div><br></div><div>John.</div></body></html>