<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>LGTM.</div><br><div><div>On Jul 17, 2013, at 6:52 PM, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr"><div>Updated version of the patch, just made it a little cleaner.<br></div><div><br></div><div><br></div><div>CC'ing Argyrios Kyrtzidis as he, from svn history, seems to know the area.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 2, 2013 at 2:57 PM, Richard Smith<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:richard@metafoo.co.uk" target="_blank">richard@metafoo.co.uk</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;">LGTM, but I'd like someone who knows this area better than I do to look at it.<br><br>--- lib/Basic/DiagnosticIDs.cpp (revision 184534)<br>+++ lib/Basic/DiagnosticIDs.cpp (working copy)<br>@@ -82,11 +84,9 @@<br> #include "clang/Basic/DiagnosticSemaKinds.inc"<br> #include "clang/Basic/DiagnosticAnalysisKinds.inc"<br> #undef DIAG<br>- { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}<br> };<br><br>Are you sure nothing is using this to find the end of the table?<br><div class="HOEnZb"><div class="h5"><br>On Tue, Jul 2, 2013 at 2:45 PM, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:<br>> Ping<br>><br>><br>> On Fri, Jun 21, 2013 at 3:42 AM, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>><br>> wrote:<br>>><br>>> The fallout of r184401 made it apparent that clang uses diagnostic ID zero<br>>> as a sentinel value while *also* assigning it to an actual diagnostic,<br>>> err_attribute_not_type_attr.<br>>><br>>> The attached patch should do two things:<br>>> * Ensure that we don't give away ID 0<br>>> * Make sure that we will assert if we attempt to use ID 0<br>>><br>>> --<br>>> David Majnemer<br>><br>><br></div></div></blockquote></div><br></div><span><diag0.diff></span></div></blockquote></div><br></body></html>