<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Specifically.<div><h1 style="font-family: sans-serif;">Revision 186511</h1><hr style="font-family: sans-serif; font-size: medium;"><form method="get" action="http://llvm.org/viewvc/llvm-project" style="margin: 0px; font-family: sans-serif; font-size: medium;"><table cellspacing="1" cellpadding="2" style="width: auto; margin: 0px; border: none;"><tbody><tr align="left" style="vertical-align: top;"><th style="vertical-align: top; white-space: nowrap;">Jump to revision:</th><td style="vertical-align: top;"><input type="text" name="revision" value="186511"> <input type="submit" value="Go"> <a href="http://llvm.org/viewvc/llvm-project?view=revision&revision=186510" title="Previous Revision" style="color: rgb(136, 0, 136);"><img alt="Previous" width="20" height="22" style="border: none;" apple-inline="yes" id="1F5B84B0-0376-473D-BA21-1F990D25A7B1" apple-width="yes" apple-height="yes" src="cid:2C29413C-0911-43CA-9972-CD5ED5528393@apple.com"></a> <a href="http://llvm.org/viewvc/llvm-project?view=revision&revision=186512" title="Next Revision" style="color: rgb(136, 0, 136);"><img width="20" height="22" alt="Next" style="border: none;" apple-inline="yes" id="C034FD77-24BF-4DFD-9CA1-7891D7142A1E" apple-width="yes" apple-height="yes" src="cid:9178A3ED-90AD-499E-9E45-131519552F08@apple.com"></a></td></tr><tr align="left" style="vertical-align: top;"><th style="vertical-align: top; white-space: nowrap;">Author:</th><td style="vertical-align: top;">rafael</td></tr><tr align="left" style="vertical-align: top;"><th style="vertical-align: top; white-space: nowrap;">Date:</th><td style="vertical-align: top;">Wed Jul 17 09:58:25 2013 CDT <em>(2 hours, 27 minutes ago)</em></td></tr><tr align="left" style="vertical-align: top;"><th style="vertical-align: top; white-space: nowrap;">Changed paths:</th><td style="vertical-align: top;"><strong>4</strong></td></tr><tr align="left" style="vertical-align: top;"><th style="vertical-align: top; white-space: nowrap;">Log Message:</th><td style="vertical-align: top;"><pre class="vc_log" style="white-space: pre-wrap; word-wrap: break-word;">Split openFileForRead into Windows and Unix versions.
This has some advantages:
* Lets us use native, utf16 windows functions.
* Easy to produce good errors on windows about trying to use a
directory when we want a file.
* Simplifies the unix version a bit.</pre></td></tr></tbody></table></form><hr style="font-family: sans-serif; font-size: medium;"><p style="font-family: sans-serif; font-size: medium;"><strong>Changed paths:</strong></p><table cellspacing="1" cellpadding="2" style="width: 965px; margin: 0px; border: none; color: rgb(0, 0, 0); font-family: sans-serif;"><thead><tr align="left" style="vertical-align: top;"><th class="vc_header_sort" style="vertical-align: top; white-space: nowrap; background-color: rgb(136, 255, 136);">Path</th><th class="vc_header" style="vertical-align: top; white-space: nowrap; background-color: rgb(204, 204, 204);">Details</th></tr></thead><tbody><tr class="vc_row_even" style="vertical-align: top; background-color: rgb(255, 255, 255);"><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Path.cpp?view=markup&pathrev=186511" title="View File Contents" style="color: rgb(136, 0, 136);"><img class="vc_icon" alt="Directory" style="border: none; padding: 0px 1px;" apple-inline="yes" id="FBA34C56-C13B-4AFB-B279-503CAD3413E2" height="16" width="16" apple-width="yes" apple-height="yes" src="cid:7827C494-3BC6-4729-AE0B-2D0BAF987E05@apple.com">llvm/trunk/lib/Support/Path.cpp</a></td><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Path.cpp?view=log&pathrev=186511" title="View Log" style="color: rgb(136, 0, 136);">modified</a> , <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Path.cpp?r1=186511&r2=186510&pathrev=186511" title="View Diff" style="color: rgb(136, 0, 136);">text changed</a></td></tr><tr class="vc_row_odd" style="vertical-align: top; background-color: rgb(240, 240, 240);"><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/Path.inc?view=markup&pathrev=186511" title="View File Contents" style="color: rgb(136, 0, 136);"><img class="vc_icon" alt="Directory" style="border: none; padding: 0px 1px;" apple-inline="yes" id="DDE258E6-4025-41F5-AE03-CD413CA3E352" height="16" width="16" apple-width="yes" apple-height="yes" src="cid:7827C494-3BC6-4729-AE0B-2D0BAF987E05@apple.com">llvm/trunk/lib/Support/Unix/Path.inc</a></td><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/Path.inc?view=log&pathrev=186511" title="View Log" style="color: rgb(136, 0, 136);">modified</a> , <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Unix/Path.inc?r1=186511&r2=186510&pathrev=186511" title="View Diff" style="color: rgb(136, 0, 136);">text changed</a></td></tr><tr class="vc_row_even" style="vertical-align: top; background-color: rgb(255, 255, 255);"><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Windows/Path.inc?view=markup&pathrev=186511" title="View File Contents" style="color: rgb(136, 0, 136);"><img class="vc_icon" alt="Directory" style="border: none; padding: 0px 1px;" apple-inline="yes" id="3AACB996-CEB2-4E6E-8A06-FF1623A8BEB1" height="16" width="16" apple-width="yes" apple-height="yes" src="cid:7827C494-3BC6-4729-AE0B-2D0BAF987E05@apple.com">llvm/trunk/lib/Support/Windows/Path.inc</a></td><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Windows/Path.inc?view=log&pathrev=186511" title="View Log" style="color: rgb(136, 0, 136);">modified</a> , <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Windows/Path.inc?r1=186511&r2=186510&pathrev=186511" title="View Diff" style="color: rgb(136, 0, 136);">text changed</a></td></tr><tr class="vc_row_odd" style="vertical-align: top; background-color: rgb(240, 240, 240);"><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/directory.ll?view=markup&pathrev=186511" title="View File Contents" style="color: rgb(136, 0, 136);"><img class="vc_icon" alt="Directory" style="border: none; padding: 0px 1px;" apple-inline="yes" id="B254401B-FEA3-43C3-B065-767430C60338" height="16" width="16" apple-width="yes" apple-height="yes" src="cid:7827C494-3BC6-4729-AE0B-2D0BAF987E05@apple.com">llvm/trunk/test/Object/directory.ll</a></td><td style="vertical-align: top;"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/directory.ll?view=log&pathrev=186511" title="View Log" style="color: rgb(136, 0, 136);">modified</a> , <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Object/directory.ll?r1=186511&r2=186510&pathrev=186511" title="View Diff" style="color: rgb(136, 0, 136);">text changed</a></td></tr></tbody></table><div><br></div><div><br></div><div><div>On Jul 17, 2013, at 10:21 AM, jahanian <<a href="mailto:fjahanian@apple.com">fjahanian@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div><br class="Apple-interchange-newline">We are suspecting that r186511 is causing numerous test failure on windows.</div><div>A typical case is:</div><div><br></div><div><div style="margin: 0px; font-size: 11px; font-family: Menlo;">C:/.../clang-build/185549/bin/Release/clang.EXE -cc1 -internal-isystem C:\...\clang-build\185549\bin\Release\..\lib\clang\3.4\include -fblocks -fobjc-gc -triple x86_64-apple-darwin -fobjc-runtime=macosx-fragile-10.5 -O0 -print-ivar-layout -emit-llvm -o /dev/null C:\...\src\tools\clang\test\CodeGenObjC\block-var-layout.m > C:\...\clang-build\185549\tools\clang\test\CodeGenObjC\Output\block-var-layout.m.tmp-64.layout</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> FileCheck -check-prefix LP64 --input-file=C:\...\clang-build\185549\tools\clang\test\CodeGenObjC\Output\block-var-layout.m.tmp-64.layout C:\...\src\tools\clang\test\CodeGenObjC\block-var-layout.m</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> --</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Exit Code: 2</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command Output (stdout):</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> --</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 0: "C:/.../clang-build/185549/bin/Release/clang.EXE" "-cc1" "-internal-isystem" "C:\...\clang-build\185549\bin\Release\..\lib\clang\3.4\include" "-fblocks" "-fobjc-gc" "-triple" "x86_64-apple-darwin" "-fobjc-runtime=macosx-fragile-10.5" "-O0" "-print-ivar-layout" "-emit-llvm" "-o" "/dev/null" "C:\...\src\tools\clang\test\CodeGenObjC\block-var-layout.m"</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 0 Result: 0</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 0 Output:</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> None</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 0 Stderr:</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 1: "FileCheck" "-check-prefix" "LP64" "--input-file=C:\...\clang-build\185549\tools\clang\test\CodeGenObjC\Output\block-var-layout.m.tmp-64.layout" "C:\...\src\tools\clang\test\CodeGenObjC\block-var-layout.m"</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 1 Result: 2</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 1 Output:</div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;"><br></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Command 1 Stderr:</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;"> Could not open input file 'C:\...\clang-build\185549\tools\clang\test\CodeGenObjC\Output\block-var-layout.m.tmp-64.layout': The process cannot access the file because it is being used by another process</div></div><div><br></div><div>- Fariborz</div></div><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">_______________________________________________</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;">cfe-commits mailing list</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><a href="mailto:cfe-commits@cs.uiuc.edu" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">cfe-commits@cs.uiuc.edu</a><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a></blockquote></div><br></div></body></html>