<div dir="ltr">Isn't it better to write these as arrays instead of pointers, if you want to micro-optimize the .rodata size and reduce relocations?<div><a href="http://glandium.org/blog/?p=2361">http://glandium.org/blog/?p=2361</a></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 16, 2013 at 1:03 AM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Tue Jul 16 00:03:10 2013<br>
New Revision: 186383<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=186383&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=186383&view=rev</a><br>
Log:<br>
Add 'const' qualifiers to static const char* variables.<br>
<br>
Modified:<br>
    cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp<br>
<br>
Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp?rev=186383&r1=186382&r2=186383&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp?rev=186383&r1=186382&r2=186383&view=diff</a><br>

==============================================================================<br>
--- cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp (original)<br>
+++ cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp Tue Jul 16 00:03:10 2013<br>
@@ -1592,8 +1592,8 @@ static const Stmt *getTerminatorConditio<br>
   return S;<br>
 }<br>
<br>
-static const char *StrEnteringLoop = "Entering loop body";<br>
-static const char *StrLoopBodyZero = "Loop body executed 0 times";<br>
+static const char *const StrEnteringLoop = "Entering loop body";<br>
+static const char *const StrLoopBodyZero = "Loop body executed 0 times";<br>
<br>
 static bool<br>
 GenerateAlternateExtensivePathDiagnostic(PathDiagnostic& PD,<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
</blockquote></div><br></div>