<div dir="ltr">Sorry, I wasn't really paying attention to this patch before.<div><br></div><div>I've been looking through the review comments and I can't seem to find the motivation for why you're writing a new layout builder from scratch (and duplicating a bunch of code) instead of taking advantage of the existing IsMsStruct flag in RecordLayoutBuilder.cpp. Is the difference between IsMsStruct and what you're implementing really that substantial?</div>
<div><br></div><div>I saw earlier in the review comments you were alluding to CodeGen crashes; that shouldn't be an issue as of r185018.</div><div><br></div><div>Please put the SemaDecl.cpp change into a separate patch.</div>
<div><br></div><div>-Eli</div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Wed, Jun 26, 2013 at 2:23 PM, Warren Hunt <span dir="ltr"><<a href="mailto:whunt@google.com" target="_blank">whunt@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Addressing 2nd round of feedback, enabling a Sema error, clang format and some minor fixes.<br>
<div><br>
Hi rnk, rsmith,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1026" target="_blank">http://llvm-reviews.chandlerc.com/D1026</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
</div> <a href="http://llvm-reviews.chandlerc.com/D1026?vs=2536&id=2578#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1026?vs=2536&id=2578#toc</a><br>
<div><div><br>
Files:<br>
include/clang/AST/ASTContext.h<br>
include/clang/Sema/Sema.h<br>
lib/AST/CMakeLists.txt<br>
lib/AST/MicrosoftRecordLayoutBuilder.cpp<br>
lib/AST/RecordLayoutBuilder.cpp<br>
lib/Sema/SemaDecl.cpp<br>
test/Sema/ms_bitfield_layout.c<br>
</div></div><br>_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@cs.uiuc.edu" target="_blank">cfe-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br>
<br></blockquote></div><br></div></div></div>