<div dir="ltr">Ping? Please review.<div style>Thanks.</div><div><br><div class="gmail_extra"><div class="gmail_quote">2013/6/17 WenHan Gu (谷汶翰) <span dir="ltr"><<a href="mailto:wenhan.gu@gmail.com" target="_blank">wenhan.gu@gmail.com</a>></span><br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Sure.<div>I'd like to add it into existing test/Sema/vfprintf-..., but it invalid the original test, so I add a new test file.</div>

<div><br></div><div><div><div class="gmail_drive_chip" style="width:396px;min-height:18px;max-height:18px;background-color:#f5f5f5;padding:5px;color:#222;font-family:arial;font-style:normal;font-weight:bold;font-size:13px;border:1px solid #ddd">


<a href="https://docs.google.com/file/d/0BwR5L-mAgdKlb0VNdGQ3WUxYRmc/edit?usp=drive_web" style="display:inline-block;overflow:hidden;text-overflow:ellipsis;white-space:nowrap;text-decoration:none;padding:1px 0px;border:none;width:100%" target="_blank"><img style="vertical-align:bottom;border:none" src="https://ssl.gstatic.com/docs/doclist/images/icon_10_generic_list.png"> <span dir="ltr" style="color:#15c;text-decoration:none;vertical-align:bottom">0001-Bugfix-De-reference-pointer-after-null-check.patch</span></a></div>


<br></div></div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">2013/6/17 Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span><br>


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">you should include a testcase in the patch. Since it was a crash, it<br>
should be sufficient to just add it to one of the files is test/.<br>
<br>
Cheers,<br>
Rafael<br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><div class="im">-- <br><div dir="ltr">Best Regards,<div>WenHan Gu (Nowar)</div></div>
</div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Best Regards,<div>WenHan Gu (Nowar)</div></div>
</div></div></div>