<div dir="ltr">As of r<span style="font-family:arial,sans-serif;font-size:13px">184616, Clang will work on function pointers that is returned from a function.</span></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Thu, Jun 20, 2013 at 2:32 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div class="h5">On Thu, Jun 20, 2013 at 2:18 PM, Eli Friedman <span dir="ltr"><<a href="mailto:eli.friedman@gmail.com" target="_blank">eli.friedman@gmail.com</a>></span> wrote:<br><div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div>On Thu, Jun 20, 2013 at 2:03 PM, Richard Trieu <span dir="ltr"><<a href="mailto:rtrieu@google.com" target="_blank">rtrieu@google.com</a>></span> wrote:<br>
</div></div><div class="gmail_extra"><div class="gmail_quote"><div><div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: rtrieu<br>
Date: Thu Jun 20 16:03:13 2013<br>
New Revision: 184470<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=184470&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=184470&view=rev</a><br>
Log:<br>
Extend -Wnon-pod-varargs to check calls made from function pointers.<br>
<br>
Modified:<br>
cfe/trunk/include/clang/Sema/Sema.h<br>
cfe/trunk/lib/Sema/SemaChecking.cpp<br>
cfe/trunk/lib/Sema/SemaExpr.cpp<br>
cfe/trunk/test/SemaCXX/vararg-non-pod.cpp<br>
<br>
Modified: cfe/trunk/include/clang/Sema/Sema.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Sema.h?rev=184470&r1=184469&r2=184470&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Sema/Sema.h?rev=184470&r1=184469&r2=184470&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/include/clang/Sema/Sema.h (original)<br>
+++ cfe/trunk/include/clang/Sema/Sema.h Thu Jun 20 16:03:13 2013<br>
@@ -7461,8 +7461,8 @@ private:<br>
const FunctionProtoType *Proto);<br>
bool CheckObjCMethodCall(ObjCMethodDecl *Method, SourceLocation loc,<br>
ArrayRef<const Expr *> Args);<br>
- bool CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall,<br>
- const FunctionProtoType *Proto);<br>
+ bool CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall,<br>
+ const FunctionProtoType *Proto);<br>
void CheckConstructorCall(FunctionDecl *FDecl,<br>
ArrayRef<const Expr *> Args,<br>
const FunctionProtoType *Proto,<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=184470&r1=184469&r2=184470&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaChecking.cpp?rev=184470&r1=184469&r2=184470&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaChecking.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaChecking.cpp Thu Jun 20 16:03:13 2013<br>
@@ -597,18 +597,24 @@ bool Sema::CheckObjCMethodCall(ObjCMetho<br>
return false;<br>
}<br>
<br>
-bool Sema::CheckBlockCall(NamedDecl *NDecl, CallExpr *TheCall,<br>
- const FunctionProtoType *Proto) {<br>
+bool Sema::CheckPointerCall(NamedDecl *NDecl, CallExpr *TheCall,<br>
+ const FunctionProtoType *Proto) {<br>
const VarDecl *V = dyn_cast<VarDecl>(NDecl);<br>
if (!V)<br>
return false;<br>
<br>
QualType Ty = V->getType();<br>
- if (!Ty->isBlockPointerType())<br>
+ if (!Ty->isBlockPointerType() && !Ty->isFunctionPointerType())<br>
return false;<br>
<br>
- VariadicCallType CallType =<br>
- Proto && Proto->isVariadic() ? VariadicBlock : VariadicDoesNotApply ;<br>
+ VariadicCallType CallType;<br>
+ if (!Proto) {<br>
+ CallType = VariadicDoesNotApply;<br>
+ } else if (Ty->isBlockPointerType()) {<br>
+ CallType = VariadicBlock;<br>
+ } else { // Ty->isFunctionPointerType()<br>
+ CallType = VariadicFunction;<br>
+ }<br>
unsigned NumProtoArgs = Proto ? Proto->getNumArgs() : 0;<br>
<br>
checkCall(NDecl,<br>
<br>
Modified: cfe/trunk/lib/Sema/SemaExpr.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=184470&r1=184469&r2=184470&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaExpr.cpp?rev=184470&r1=184469&r2=184470&view=diff</a><br>
==============================================================================<br>
--- cfe/trunk/lib/Sema/SemaExpr.cpp (original)<br>
+++ cfe/trunk/lib/Sema/SemaExpr.cpp Thu Jun 20 16:03:13 2013<br>
@@ -4464,7 +4464,7 @@ Sema::BuildResolvedCallExpr(Expr *Fn, Na<br>
if (BuiltinID)<br>
return CheckBuiltinFunctionCall(BuiltinID, TheCall);<br>
} else if (NDecl) {<br>
- if (CheckBlockCall(NDecl, TheCall, Proto))<br>
+ if (CheckPointerCall(NDecl, TheCall, Proto))<br>
return ExprError();<br>
}<br></blockquote><div><br></div></div></div><div>What if someone does e.g. (FuncReturningVarargsFuncPtr())(a,b,c)?</div><span><font color="#888888"><div> </div><div>-Eli</div></font></span></div><br></div></div>
</blockquote></div><br></div></div></div><div class="gmail_extra">$ cat PR16353.cc</div><div class="gmail_extra"><div class="gmail_extra">struct Foo {</div><div class="gmail_extra"> Foo() {}</div><div class="gmail_extra">
Foo(const Foo&) {}</div><div class="gmail_extra">};</div><div class="gmail_extra"><br></div><div class="gmail_extra">void f(...);</div><div class="gmail_extra"><br></div><div class="gmail_extra">typedef void (*vararg_ptr)(...);</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">vararg_ptr g();</div><div class="gmail_extra"><br></div><div class="gmail_extra">void h() {</div><div class="gmail_extra"> Foo foo;</div><div class="gmail_extra">
<br></div><div class="gmail_extra"> vararg_ptr ptr = f;</div><div class="gmail_extra"> f(foo);</div><div class="gmail_extra"> ptr(foo);</div><div class="gmail_extra"> (g())(foo);</div><div class="gmail_extra">}</div>
<div class="gmail_extra">
$ clang -fsyntax-only -Wall PR16353.cc</div><div class="gmail_extra"><div class="gmail_extra">PR16353.cc:26:5: error: cannot pass object of non-POD type 'Foo' through variadic function; call will abort at runtime [-Wnon-pod-varargs]</div>
<div class="gmail_extra"> f(foo);</div><div class="gmail_extra"> ^</div><div class="gmail_extra">PR16353.cc:27:7: error: cannot pass object of non-POD type 'Foo' through variadic function; call will abort at runtime [-Wnon-pod-varargs]</div>
<div class="gmail_extra"> ptr(foo);</div><div class="gmail_extra"> ^</div><div class="gmail_extra">2 errors generated.</div><div>$ gcc -fsyntax-only -Wall PR16353.cc<br></div><div><div>PR16353.cc: In function ‘void h()’:</div>
<div>PR16353.cc:26:8: error: cannot pass objects of non-trivially-copyable type ‘struct Foo’ through ‘...’</div><div>PR16353.cc:27:10: error: cannot pass objects of non-trivially-copyable type ‘struct Foo’ through ‘...’</div>
<div>PR16353.cc:28:12: error: cannot pass objects of non-trivially-copyable type ‘struct Foo’ through ‘...’</div></div><div><br></div><div>Looks like Clang doesn't detect it.</div></div></div></div>
</blockquote></div><br></div>