<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jun 20, 2013, at 12:49 PM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:</div><blockquote type="cite"><div dir="ltr">On Thu, Jun 20, 2013 at 1:37 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div><span style="color:rgb(34,34,34)">Good point, sorry.</span><br>
</div><br></div><div>Hmm. It looks like ActOnStartOfFunctionDef, ActOnStartOfObjCMethodDef, ActOnBlockArguments, and addLambdaParameters all have basically the same loop in them, but doing slightly different checks for no particular reason. And there's already a CheckParmsForFunctionDef method, but it's apparently not called for ObjC methods.</div>
<div><br></div><div>I think it makes sense to have a single method called in all of these cases which performs the basic checks, sets ownership, and pushes parameters into scope. That method would be a natural place for your call to FinalizeVarWithDestructor.</div>
</div></blockquote><div><br></div><div>I ended up putting it in CheckParmsForFunctionDef. Probably ObjC methods should be calling that?</div></div></div></div>
</blockquote></div><br><div>I was hoping that you'd do the refactoring to make that happen. :)</div><div><br></div><div>John.</div></body></html>