<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jun 19, 2013, at 5:32 AM, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:</div><blockquote type="cite"><div dir="ltr">On Tue, Jun 18, 2013 at 8:07 PM, John McCall <span dir="ltr"><<a href="mailto:rjmccall@apple.com" target="_blank">rjmccall@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Jun 9, 2013, at 9:45 AM, Reid Kleckner <<a href="mailto:reid@kleckner.net" target="_blank">reid@kleckner.net</a>> wrote:<br>
> Author: rnk<br>
> Date: Sun Jun 9 11:45:02 2013<br>
> New Revision: 183631<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=183631&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=183631&view=rev</a><br>
> Log:<br>
> [CodeGen] Move EHScopeStack to CGCleanup.h from CodeGenFunction.h<br>
><br>
> No functionality change. CGCleanup.cpp provides the implementation for<br>
> EHScopeStack, so it seems more consistent to place the class definition<br>
> in CGCleanup.h.<br>
<br>
</div>So, I specifically wasn't doing this because I didn't want to include<br>
CGCleanup.h in every file in IR-gen, basically because I didn't want<br>
random files depending on the cleanup-stack details.<br></blockquote><div><br></div><div>Hm. I needed this in order to reference EHScopeStack::stable_iterator from CallArgList in CGCall.h, which is included by CodeGenFunction.h. I couldn't forward declare it, so this seemed cleaner.</div>
<div><br></div><div style="">lib/CodeGen/CGEHScopeStack.h then?</div>
</div></div></div>
</blockquote></div><br><div>Just EHScopeStack.h, please.</div><div><br></div><div>John.</div></body></html>