<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 17, 2013, at 12:33 , Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Mon, Jun 17, 2013 at 11:40 AM, Jordan Rose <<a href="mailto:jordan_rose@apple.com">jordan_rose@apple.com</a>> wrote:<br><blockquote type="cite"><br>On Jun 16, 2013, at 17:01 , Richard Smith <<a href="mailto:richard-llvm@metafoo.co.uk">richard-llvm@metafoo.co.uk</a>><br>wrote:<br><br>+// FIXME: Why are DeprecatedImplementations and DeprecatedWritableStr<br>+// not in this group?<br>+def Deprecated : DiagGroup<"deprecated", [DeprecatedDeclarations,<br>+ DeprecatedRegister]>,<br><br><br>As I understand it, because -Wdeprecated is for user deprecations (i.e.<br>__attribute__((deprecated))), not language deprecations.<br></blockquote><br>That doesn't match our existing practice, which is somewhat<br>inconsistent but seems to be closer to using -Wdeprecated-declarations<br>for user deprecations, and -Wdeprecated for all deprecations.<br>Specifically, prior to my changes:<br><br>-Wdeprecated contained:<br> -Wdeprecated-declarations<br> access declarations<br> bool increment<br> __vector long<br> deprecated driver arguments<br><br>-Wdeprecated-declarations contained:<br> __attribute__((deprecated))<br> "maybe deprecated because receiver type is unknown" (???)<br> use of C-style parameters in objective-C method declarations (???)<br><br>And -Wdeprecated-objc-isa-usage, -Wdeprecated-writable-strings, and<br>-Wdeprecated-implementations are not part of any other group.<br><br>Maybe we should move those two (???) warnings out of<br>-Wdeprecated-declarations and into -Wdeprecated?<br></blockquote></div><br><div>Ah, I didn't notice some of those other bare deprecations. (I just looked in DiagnosticSemaKinds.) I guess I don't care what we do as long as user deprecations are separate from language deprecations, whether that's introducing another flag for those under -Wdeprecated-declarations, moving the ??? warnings up to -Wdeprecated, or moving the language deprecations <i>out</i> of -Wdeprecated. I can see the other deprecation-related warnings being moved under -Wdeprecated in the first two cases.</div><div><br></div><div>Jordan</div></body></html>