<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’ve made a first stab at a feature for the modularize tool for finding preprocessor conditionals that might be problematic for modules.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">It uses a derived PPCallbacks class (thanks of the info on this, Sean) to track the preprocessing of files, and if it finds conditional directives (#if, #elif, #ifdef, #ifndef) whose conditionals resolve differently in other instances of
the header being processed, it produces messages like this:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">warning: The instances of header InconsistentSubHeader.h have different contents after preprocessing:<o:p></o:p></p>
<p class="MsoNormal"> When included or nested in these top-level headers:<o:p></o:p></p>
<p class="MsoNormal"> InconsistentHeader1.h<o:p></o:p></p>
<p class="MsoNormal"> This preprocessor directive is mismatched (the parentheses show the condition after macro substitution):<o:p></o:p></p>
<p class="MsoNormal"> InconsistentSubHeader.h:9:1: #if SYMBOL == 1 (#if 1 == 1)<o:p></o:p></p>
<p class="MsoNormal"> When included or nested in these top-level headers:<o:p></o:p></p>
<p class="MsoNormal"> InconsistentHeader2.h<o:p></o:p></p>
<p class="MsoNormal"> This preprocessor directive is mismatched (the parentheses show the condition after macro substitution):<o:p></o:p></p>
<p class="MsoNormal"> InconsistentSubHeader.h:9:1: #if SYMBOL == 1 (#if 2 == 1)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’ve enclose both a patch relative to tools/clang/tools/extra, and a zip file, if the latter is easier to read for new files.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">-John Thompson<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>